Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

Jakub Kicinski
2021-02-03T18:06:49Z

On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote:
> >> Jakub, Dave, Adding you both to get your reviews on this series. I've
> >> provided an explanation above and in the previous iteration [1].
> >
> >Let's be clear what the review would be for. Yet another QMI chardev
> >or the "UCI" direct generic user space to firmware pipe?
>
> The current patchset only supports QMI channel so I'd request you to
> review the chardev node created for it. The QMI chardev node created
> will be unique for the MHI bus and the number of nodes depends on the
> MHI controllers in the system (typically 1 but not limited).

If you want to add a MHI QMI driver, please write a QMI-only driver.
This generic "userspace client interface" driver is a no go. Nobody will
have the time and attention to police what you throw in there later.