From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D81FCE7A89 for ; Sat, 23 Sep 2023 11:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230500AbjIWL0e (ORCPT ); Sat, 23 Sep 2023 07:26:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230491AbjIWL0d (ORCPT ); Sat, 23 Sep 2023 07:26:33 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7690F198; Sat, 23 Sep 2023 04:26:24 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38NBNxnT004905; Sat, 23 Sep 2023 11:26:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=bWTOsBbqIB9GxAQEeNjWm91N5pgYFPfSs0SRTZgW/JA=; b=NBa0vT0pBZPm0I2NNydwLXM84me17XGljcPaSRTsmXPqE3ApssH7H4F87ybx6Nw7pgcp qP2Gr38zJrDkcsfTCYU4Ntbro5MHBI1o3nZ1mJIYQ1nUMvxE5x3pHtUaM9FVUocF80yY F4jMc7Q+z4nxuq/5OIUGp6lFoB+vFO7UO5gJQcgdXYUpGsowDA9IOBNxn/9CgNOT2+SQ jr5EjF2lXht4YYwj0HL+z+Acqhm2dSoHJ9m1k5TqDIU5zAjvYz3gK8l1/ZrIN6MzoLtL 6OXND/Dm0YNsz9DuQfbHO5BXBkDEGPPICSyHknOmGbfNYiakKo12ORfYBiuwkAaePtrJ hg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t9r88gq2u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 23 Sep 2023 11:26:10 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38NBQ9jl015317 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 23 Sep 2023 11:26:09 GMT Received: from [10.253.9.19] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Sat, 23 Sep 2023 04:26:05 -0700 Message-ID: <164945f5-dde9-bfe7-80f4-9ae6736a6259@quicinc.com> Date: Sat, 23 Sep 2023 19:26:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 To: Stephen Boyd , , , , , , , , , , CC: , , , , References: <20230901091823.30242-1-quic_luoj@quicinc.com> <20230901091823.30242-5-quic_luoj@quicinc.com> <27ae3297ad161fd67706db70b402db04.sboyd@kernel.org> <16d09acf-7bdd-04ee-6faf-936c0366df03@quicinc.com> <17681a9f756cc70a190c674c51b90140.sboyd@kernel.org> <5a4805f7-f802-b1ba-9804-59c0fe6c7f26@quicinc.com> <92058c25fb11b75ee0a2298a684825e9.sboyd@kernel.org> <82adb75659e0d278e25b65b0e81df99a.sboyd@kernel.org> <9952fa20-a27f-3240-cc49-5c5109febfc1@quicinc.com> <580f3934ab1171e27d785db7362c342d.sboyd@kernel.org> Content-Language: en-US From: Jie Luo In-Reply-To: <580f3934ab1171e27d785db7362c342d.sboyd@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: dbrRdHWrDOisq1ggy48qblpjG8hk83mP X-Proofpoint-GUID: dbrRdHWrDOisq1ggy48qblpjG8hk83mP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-23_08,2023-09-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 mlxlogscore=969 adultscore=0 impostorscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309230095 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 9/15/2023 12:30 AM, Stephen Boyd wrote: > Quoting Jie Luo (2023-09-12 20:27:25) >> >> >> On 9/13/2023 1:18 AM, Stephen Boyd wrote: >>> Quoting Jie Luo (2023-09-12 05:07:02) >>>> >>>> and freq_tbl are necessary to this clock. >>> >>> I still don't see why the freq_tbl is necessary. >> >> Hi Stephen, >> For clk_rcg2_ops, freq_tbl is used to find the closest rate to decided >> the parent clock, the configuration of clock source and clock divider >> are saved in the freq_tbl to configure the RCG hardware register, the >> mapping of parent clock and hardware register value is decided by the >> freq_tbl for the RCG clock. > > The divider is always 1. The frequency is the frequency of the parent. > The two pieces of information are already known without the frequency > table. Why is it needed? Hi Stephen, i uploaded the new patchset V9 to remove these redundant freq_tbl by using the clk_ops clk_ops clk_rcg2_mux_closest_ops, thanks for this suggestion for the code improvement. Best Regards, Jie