From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries
Date: Thu, 30 Jun 2022 07:44:25 -0600 [thread overview]
Message-ID: <1656596665.792233.2569459.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220630043536.3308546-2-bryan.odonoghue@linaro.org>
On Thu, 30 Jun 2022 05:35:35 +0100, Bryan O'Donoghue wrote:
> msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should
> declare syscon as they have drivers that use syscon inside of the apcs-kpss
> block.
>
> grep apcs arch/arm64/boot/dts/qcom/* | grep syscon
>
> Add in the additional syscon in the documentation for the above mentioned
> parts.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../mailbox/qcom,apcs-kpss-global.yaml | 44 ++++++++++---------
> 1 file changed, 24 insertions(+), 20 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.example.dtb: mailbox@b011000: compatible: 'oneOf' conditional failed, one must be fixed:
['qcom,qcs404-apcs-apps-global'] is too short
'qcom,qcs404-apcs-apps-global' is not one of ['qcom,ipq6018-apcs-apps-global', 'qcom,ipq8074-apcs-apps-global', 'qcom,msm8976-apcs-kpss-global', 'qcom,msm8996-apcs-hmss-global', 'qcom,msm8998-apcs-hmss-global', 'qcom,qcm2290-apcs-hmss-global', 'qcom,sc7180-apss-shared', 'qcom,sc8180x-apss-shared', 'qcom,sdm660-apcs-hmss-global', 'qcom,sdm845-apss-shared', 'qcom,sm6125-apcs-hmss-global', 'qcom,sm6115-apcs-hmss-global', 'qcom,sm8150-apss-shared']
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-06-30 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 4:35 [PATCH 0/2] Two apcs-kpss-global.yaml fixes Bryan O'Donoghue
2022-06-30 4:35 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Bryan O'Donoghue
2022-06-30 13:44 ` Rob Herring [this message]
2022-06-30 13:51 ` Bryan O'Donoghue
2022-06-30 18:37 ` Krzysztof Kozlowski
2022-06-30 4:35 ` [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names Bryan O'Donoghue
2022-06-30 13:44 ` Rob Herring
2022-06-30 18:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1656596665.792233.2569459.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox