From: Rob Herring <robh@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: linux-pm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag
Date: Thu, 30 Jun 2022 07:44:25 -0600 [thread overview]
Message-ID: <1656596665.853599.2569463.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220630055723.704605-2-leo.yan@linaro.org>
On Thu, 30 Jun 2022 13:57:18 +0800, Leo Yan wrote:
> To support path tag in icc-rpm driver, the "#interconnect-cells"
> property is updated as enumerate values: 1 or 2. Setting to 1 means
> it is compatible with old DT binding that interconnect path only
> contains node id; if set to 2 for "#interconnect-cells" property, then
> the second specifier is used as a tag (e.g. vote for which buckets).
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> .../devicetree/bindings/interconnect/qcom,rpm.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml:49:11: [error] syntax error: expected <block end>, but found '<scalar>' (syntax)
dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/interconnect/qcom,rpm.example.dts'
Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml:49:11: did not find expected key
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/interconnect/qcom,rpm.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml:49:11: did not find expected key
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml: ignoring, error parsing file
make: *** [Makefile:1404: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-06-30 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 5:57 [PATCH v2 0/5] interconnect: qcom: icc-rpm: Support bucket Leo Yan
2022-06-30 5:57 ` [PATCH v2 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag Leo Yan
2022-06-30 13:44 ` Rob Herring [this message]
2022-07-01 10:44 ` Leo Yan
2022-06-30 5:57 ` [PATCH v2 2/5] interconnect: qcom: Move qcom_icc_xlate_extended() to a common file Leo Yan
2022-06-30 5:57 ` [PATCH v2 3/5] interconnect: qcom: icc-rpm: Change to use qcom_icc_xlate_extended() Leo Yan
2022-06-30 5:57 ` [PATCH v2 4/5] interconnect: qcom: icc-rpm: Support multiple buckets Leo Yan
2022-06-30 5:57 ` [PATCH v2 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1656596665.853599.2569463.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox