From: Rob Herring <robh@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
linux-clk@vger.kernel.org,
Mike Turquette <mturquette@baylibre.com>,
devicetree@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH v2 2/9] dt-bindings: clock: Add SM8550 TCSR CC clocks
Date: Wed, 23 Nov 2022 15:17:54 -0600 [thread overview]
Message-ID: <166923784873.2501231.6595702811083404727.robh@kernel.org> (raw)
In-Reply-To: <20221123142009.594781-3-abel.vesa@linaro.org>
On Wed, 23 Nov 2022 16:20:02 +0200, Abel Vesa wrote:
> Add bindings documentation for clock TCSR driver on SM8550.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Changes since v1:
> * based on recent bindings, like Krzysztof asked
> * used qcom,gcc.yaml and dropped redundant properties
> * used additionalProperties instead unevaluatedProperties
> * renamed qcom,tcsrcc-sm8550.h to qcom,sm8550-tcsrcc.h, to match
> compatible
> * added dual lincese to qcom,sm8550-tcsrcc.h
> * moved patch to the beginning of patchset
> * dropped redundant "bindings" from subject line
>
> .../bindings/clock/qcom,sm8550-tcsrcc.yaml | 39 +++++++++++++++++++
> .../dt-bindings/clock/qcom,sm8550-tcsrcc.h | 18 +++++++++
> 2 files changed, 57 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.yaml
> create mode 100644 include/dt-bindings/clock/qcom,sm8550-tcsrcc.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.yaml: allOf:0: '$ref qcom,gcc.yaml#' is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.yaml: ignoring, error in schema: allOf: 0
Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.example.dtb:0:0: /example-0/clock-controller@1fc0000: failed to match any schema with compatible: ['qcom,sm8550-tcsrcc']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221123142009.594781-3-abel.vesa@linaro.org
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command.
next prev parent reply other threads:[~2022-11-23 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 14:20 [PATCH v2 0/9] clk: qcom: Add support for SM8550 Abel Vesa
2022-11-23 14:20 ` [PATCH v2 1/9] dt-bindings: clock: Add SM8550 GCC clocks Abel Vesa
2022-11-24 11:48 ` Krzysztof Kozlowski
2022-11-23 14:20 ` [PATCH v2 2/9] dt-bindings: clock: Add SM8550 TCSR CC clocks Abel Vesa
2022-11-23 21:17 ` Rob Herring [this message]
2022-11-24 11:51 ` Krzysztof Kozlowski
2022-11-23 14:20 ` [PATCH v2 3/9] clk: qcom: gdsc: Add configurable poll timeout Abel Vesa
2022-11-23 14:20 ` [PATCH v2 4/9] clk: qcom: Add LUCID_OLE PLL type for SM8550 Abel Vesa
2022-11-23 14:20 ` [PATCH v2 5/9] clk: qcom: Add clock driver " Abel Vesa
2022-11-23 14:20 ` [PATCH v2 6/9] dt-bindings: clock: Add RPMHCC " Abel Vesa
2022-11-23 14:20 ` [PATCH v2 7/9] dt-bindings: clock: qcom,rpmh: Add CXO PAD clock IDs Abel Vesa
2022-11-23 14:20 ` [PATCH v2 8/9] clk: qcom: rpmh: Add support for SM8550 rpmh clocks Abel Vesa
2022-11-23 16:12 ` Konrad Dybcio
2022-11-23 14:20 ` [PATCH v2 9/9] clk: qcom: Add TCSR clock driver for SM8550 Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166923784873.2501231.6595702811083404727.robh@kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox