From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB7B2C7EE23 for ; Tue, 23 May 2023 08:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235921AbjEWIV6 (ORCPT ); Tue, 23 May 2023 04:21:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236184AbjEWIVf (ORCPT ); Tue, 23 May 2023 04:21:35 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24889E5D for ; Tue, 23 May 2023 01:18:58 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-96fbe7fbdd4so500053266b.3 for ; Tue, 23 May 2023 01:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684829936; x=1687421936; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jlLi+ycwQXT/s4WU1mgXfkcIcnCNUrHoMrkamB93Vuw=; b=xBngffbN/nhpbXGMLWbcHLe5VnCh6R2stJ12kZW3ky6lvJVCCvIN+VsG5aiKB1I+Ns 34A96dRcYq9VmS5IVZRD56HxpB1+f/DPCM2VMherQp2h2tV6RMPZEn5rGEmyLaGqHbgv rPaYqNqknPq+bF3Fec9HR2f3+7+MZn8W7LBvEFupA9ut/Kj2mVgCjkJnN+6HvlVC1kcR Sivv+Xkcc5KOTmp2qcWPN6PFQYmAjRGXf7hksjddEbNFIAiPbJ8rNV5Y5WqpEQn3hZxR VPkl0vyKNrcrr1QcziGpHKARg/MxwGjAhlmT3RfJUfPlr6LXXRm8piNBl+gQBAFRyAMN zRaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684829936; x=1687421936; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jlLi+ycwQXT/s4WU1mgXfkcIcnCNUrHoMrkamB93Vuw=; b=NhheNxOnS7ofmG1nPsVPTrtUl4uBv8stuuDLV8Xc480uwL33DoC9TGQJ9vyuVep/xu Vpj77U6Aj527w1W3A1/rwLst4mE4RK7ioo2zjsnGS+gfDKpqK549pMAfPXlnn74VaaSV DALxT49bvA8h3ggNFHZ8/70lS5nv7NjgRUIgraFaYCnGlQ4QMv2N7MUfpFHCUrEtGahM 85/VHCMetfPg1uVDq0To4NA5S3sdGyUTrtlcKpXn6yhFTL4uzTHnlZzYXi4b7eD9GzTf nKMNLNvy2ufpjg6FrAC9U+K4jJaK1STFYD1CmNg2kbmLWVdw2/uXIzRB06B+yK/le275 1z0Q== X-Gm-Message-State: AC+VfDwoFRz58Cm8zli+XWBxEiX9WhhRJur6BTfPK/lCzjBzV5lIXoVO T8fSWs3k7FAVJTq+Gj5/SvAUHg== X-Google-Smtp-Source: ACHHUZ5q1rbkyTP3VBE77IeCogBVNMojIQwKmhDiZgShpgGhFEFrKHs6LoV4mjCuEeutALVhZt49Cw== X-Received: by 2002:ac2:5298:0:b0:4ef:eb50:4d3d with SMTP id q24-20020ac25298000000b004efeb504d3dmr4022870lfm.18.1684829082167; Tue, 23 May 2023 01:04:42 -0700 (PDT) Received: from [192.168.1.101] (abyk138.neoplus.adsl.tpnet.pl. [83.9.30.138]) by smtp.gmail.com with ESMTPSA id h13-20020ac2596d000000b004f11eb32f20sm1266058lfp.13.2023.05.23.01.04.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 01:04:41 -0700 (PDT) Message-ID: <1669ecc5-1845-e671-83f4-19ee14d37ce5@linaro.org> Date: Tue, 23 May 2023 10:04:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes Content-Language: en-US To: Bjorn Andersson , Bjorn Andersson Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Akhil P Oommen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, johan@kernel.org, mani@kernel.org References: <20230523011522.65351-1-quic_bjorande@quicinc.com> <20230523011522.65351-4-quic_bjorande@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230523011522.65351-4-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23.05.2023 03:15, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the > Lenovo ThinkPad X13s. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - None > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 26 +++++++++++++++++++ > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 26 +++++++++++++++++++ > 2 files changed, 52 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index 5b25d54b9591..547277924ea3 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -210,6 +210,11 @@ vreg_wwan: regulator-wwan { > }; > > reserved-memory { > + gpu_mem: gpu-mem@8bf00000 { The ZAP region is very seldom moved around, and I wouldn't expect it to be uncommon among the very usecase-specific 8280 machines. > + reg = <0 0x8bf00000 0 0x2000>; > + no-map; > + }; > + > linux,cma { > compatible = "shared-dma-pool"; > size = <0x0 0x8000000>; > @@ -259,6 +264,10 @@ usb1_sbu_mux: endpoint { > }; > }; > > +&adreno_smmu { > + status = "okay"; > +}; Ugh. Should definitely be enabled by default. > + > &apps_rsc { > regulators-0 { > compatible = "qcom,pm8350-rpmh-regulators"; > @@ -376,6 +385,23 @@ &dispcc0 { > status = "okay"; > }; > > +&gmu { > + status = "okay"; > +}; You can keep the GMU enabled by default as well, it won't "probe" on its own (the GPU's hw_init calls its registration) > + > +&gpu { > + status = "okay"; > + > + zap-shader { > + memory-region = <&gpu_mem>; > + firmware-name = "qcom/sc8280xp/qcdxkmsuc8280.mbn"; > + }; > +}; > + > +&gpucc { > + status = "okay"; > +}; Clock controllers have no reason to be off by default. Konrad > + > &mdss0 { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index bdcba719fc38..5ef3f4c07d75 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -264,6 +264,11 @@ vreg_wwan: regulator-wwan { > }; > > reserved-memory { > + gpu_mem: gpu-mem@8bf00000 { > + reg = <0 0x8bf00000 0 0x2000>; > + no-map; > + }; > + > linux,cma { > compatible = "shared-dma-pool"; > size = <0x0 0x8000000>; > @@ -359,6 +364,10 @@ usb1_sbu_mux: endpoint { > }; > }; > > +&adreno_smmu { > + status = "okay"; > +}; > + > &apps_rsc { > regulators-0 { > compatible = "qcom,pm8350-rpmh-regulators"; > @@ -518,6 +527,23 @@ &dispcc0 { > status = "okay"; > }; > > +&gmu { > + status = "okay"; > +}; > + > +&gpu { > + status = "okay"; > + > + zap-shader { > + memory-region = <&gpu_mem>; > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn"; > + }; > +}; > + > +&gpucc { > + status = "okay"; > +}; > + > &mdss0 { > status = "okay"; > };