Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Paul Sajna <sajattack@postmarketos.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	David Heidelberg <david@ixit.cz>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Amir Dahan <system64fumo@protonmail.com>,
	Christopher Brown <crispybrown@gmail.com>
Subject: Re: [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id
Date: Sun, 14 Sep 2025 12:22:05 +0200	[thread overview]
Message-ID: <166a4376-e082-4acf-9215-22cd46ce7467@kernel.org> (raw)
In-Reply-To: <20250913-judyln-dts-v1-8-23b4b7790dce@postmarketos.org>

On 14/09/2025 01:56, Paul Sajna wrote:
> SDM845 msm-id and board-id added


We see this from the diff. Don't repeat the diff in the commit msg,
that's not its purpose. You need to explain why. Especially that these
properties are deprecated and should not be used in general.


Best regards,
Krzysztof

  reply	other threads:[~2025-09-14 10:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-13 23:56 [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-09-13 23:56 ` [PATCH 01/11] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
2025-09-15  0:19   ` Dmitry Baryshkov
2025-09-15  0:28     ` Paul Sajna
2025-09-15  7:20   ` Konrad Dybcio
2025-09-13 23:56 ` [PATCH 02/11] arm64: dts: qcom sdm845-lg-judyln: Add battery and charger Paul Sajna
2025-09-14 10:20   ` Krzysztof Kozlowski
2025-09-13 23:56 ` [PATCH 03/11] arm64: dts: qcom: sdm845-lg-common: Add leds Paul Sajna
2025-09-15  0:24   ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 04/11] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
2025-09-15  0:25   ` Dmitry Baryshkov
2025-09-15  0:34     ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 05/11] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
2025-09-15  0:28   ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 06/11] arm64: dts: qcom: sdm845-lg-common: Add wifi node Paul Sajna
2025-09-15  0:32   ` Dmitry Baryshkov
2025-09-15  3:57     ` Paul Sajna
2025-09-15  7:18   ` Konrad Dybcio
2025-09-13 23:56 ` [PATCH 07/11] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes Paul Sajna
2025-09-15  0:33   ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 08/11] arm64: dts: qcom: sdm845-lg-common: Add qcom id Paul Sajna
2025-09-14 10:22   ` Krzysztof Kozlowski [this message]
2025-09-13 23:56 ` [PATCH 09/11] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
2025-09-15  0:34   ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 10/11] arm64: dts: qcom: sdm845-lg-judyln: Sort and cleanup nodes Paul Sajna
2025-09-15  0:35   ` Dmitry Baryshkov
2025-09-13 23:56 ` [PATCH 11/11] arm64: dts: qcom: sdm845-lg-common: " Paul Sajna
2025-09-14 10:24   ` Krzysztof Kozlowski
2025-11-18 20:13 ` [PATCH 00/11] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166a4376-e082-4acf-9215-22cd46ce7467@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crispybrown@gmail.com \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sajattack@postmarketos.org \
    --cc=system64fumo@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox