From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AA8C04FDE for ; Fri, 9 Dec 2022 17:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229770AbiLIRlg (ORCPT ); Fri, 9 Dec 2022 12:41:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbiLIRle (ORCPT ); Fri, 9 Dec 2022 12:41:34 -0500 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 384FA53EC8; Fri, 9 Dec 2022 09:41:33 -0800 (PST) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-1442977d77dso571922fac.6; Fri, 09 Dec 2022 09:41:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lfLx+eHbQgdk9kX2AxUh539ocDqtDYlE8mRQQ26b+yU=; b=OH4YzqvJSTxOhyP7USYic2+3okVDgaREE8YkhTbTyR+ydBIZ99XQjQDU6Vsxb3wi8a jKt8Ur4cma/8A0OPKfbxmjqYnD1PbvXgaPpgm8+rPAIQBk2rZpKkyF5Eoc0xkjHrC+fG 2xcY5/iccmZcBqFBkKam+6ngDGi4p6tgtMpC4Chpz5Kqox/uW7DF+BQ62QHrxSWV5+6x DlcMM3n+XaCF2HuYol39MdmojMwCkA7SthWvc8qK3DpSR5/Q2yS3vrAqLM5dZAsSACH2 dCiciFk4vFMZLUSFS0arBfSXPjbvYlZ7c37wHIfREqMBncgYwbvuFvoXtKf3KkngfPB0 TG0w== X-Gm-Message-State: ANoB5pn9eT4rAC61opHyto04kgmUDNat2wny75tNTSBrnvH0Yyn9FYHj VbbqSEZHutZIPPZyRAQB1w== X-Google-Smtp-Source: AA0mqf4TJZVJBOiEUEB4kjkImACvkIXApXTLaNah1G9II/0nko8+ADK6eFGTQun035lZBJG4M6/AKg== X-Received: by 2002:a05:6870:da0c:b0:144:1078:ed9 with SMTP id go12-20020a056870da0c00b0014410780ed9mr3477199oab.25.1670607692409; Fri, 09 Dec 2022 09:41:32 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id l17-20020a056870f15100b0010d7242b623sm1120461oac.21.2022.12.09.09.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 09:41:31 -0800 (PST) Received: (nullmailer pid 3384468 invoked by uid 1000); Fri, 09 Dec 2022 17:41:31 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Luca Weiss Cc: linux-scsi@vger.kernel.org, Bart Van Assche , Alim Akhtar , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Bjorn Andersson , Rob Herring , linux-kernel@vger.kernel.org, Avri Altman , ~postmarketos/upstreaming@lists.sr.ht, Konrad Dybcio , Andy Gross , devicetree@vger.kernel.org In-Reply-To: <20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com> References: <20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com> Message-Id: <167060767531.3383988.11067282925964862729.robh@kernel.org> Subject: Re: [PATCH] dt-bindings: ufs: qcom: Add reg-names property for ICE Date: Fri, 09 Dec 2022 11:41:31 -0600 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 09 Dec 2022 15:29:47 +0100, Luca Weiss wrote: > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this > in the bindings so the existing dts can validate successfully. > > Also sm8450 is using ICE since commit 276ee34a40c1 ("arm64: dts: qcom: > sm8450: add Inline Crypto Engine registers and clock") so move the > compatible to the correct if. > > Signed-off-by: Luca Weiss > --- > (no cover subject) > > The only remaining validation issues I see is the following on sc8280xp-crd.dtb > and sa8540p-ride.dtb: > > Unevaluated properties are not allowed ('required-opps', 'dma-coherent' were unexpected) > > Maybe someone who knows something about this can handle this? > > And the patch adding qcom,sm6115-ufshc hasn't been applied yet. > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: 'reg-names' is a required property From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.