From: Rob Herring <robh@kernel.org>
To: Melody Olvera <quic_molvera@quicinc.com>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-clk@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clocks
Date: Sat, 17 Dec 2022 08:47:04 -0600 [thread overview]
Message-ID: <167124498396.424274.14851039167580060223.robh@kernel.org> (raw)
In-Reply-To: <20221216230722.21404-2-quic_molvera@quicinc.com>
On Fri, 16 Dec 2022 15:07:21 -0800, Melody Olvera wrote:
> Add device tree bindings for global clock controller on QDU1000 and
> QRU1000 SoCs.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> .../bindings/clock/qcom,qdu1000-gcc.yaml | 51 +++++
> include/dt-bindings/clock/qcom,qdu1000-gcc.h | 175 ++++++++++++++++++
> 2 files changed, 226 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
> create mode 100644 include/dt-bindings/clock/qcom,qdu1000-gcc.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.example.dtb: clock-controller@100000: '#clock-cells', '#power-domain-cells', '#reset-cells', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221216230722.21404-2-quic_molvera@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2022-12-17 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 23:07 [PATCH v5 0/2] clk: qcom: Add clocks for the QDU1000 and QRU1000 SoCs Melody Olvera
2022-12-16 23:07 ` [PATCH v5 1/2] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clocks Melody Olvera
2022-12-17 14:47 ` Rob Herring [this message]
2022-12-19 15:06 ` Rob Herring
2022-12-19 22:13 ` Melody Olvera
2022-12-16 23:07 ` [PATCH v5 2/2] clk: qcom: Add QDU1000 and QRU1000 GCC support Melody Olvera
2022-12-19 16:25 ` Dmitry Baryshkov
2022-12-19 22:13 ` Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167124498396.424274.14851039167580060223.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox