Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Vivek Aknurwar <quic_viveka@quicinc.com>
To: <djakov@kernel.org>
Cc: <quic_mdtipton@quicinc.com>, <quic_okukatla@quicinc.com>,
	<linux-pm@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Vivek Aknurwar <quic_viveka@quicinc.com>
Subject: [PATCH] interconnect: Skip call into provider if initial bw is zero
Date: Fri, 13 Jan 2023 14:07:59 -0800	[thread overview]
Message-ID: <1673647679-15216-1-git-send-email-quic_viveka@quicinc.com> (raw)

Currently framework sets bw even when init bw requirements are zero during
provider registration, thus resulting bulk of set bw to hw.
Avoid this behaviour by skipping provider set bw calls if init bw is zero.

Signed-off-by: Vivek Aknurwar <quic_viveka@quicinc.com>
---
 drivers/interconnect/core.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 25debde..43ed595 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -977,14 +977,17 @@ void icc_node_add(struct icc_node *node, struct icc_provider *provider)
 	node->avg_bw = node->init_avg;
 	node->peak_bw = node->init_peak;
 
-	if (provider->pre_aggregate)
-		provider->pre_aggregate(node);
-
-	if (provider->aggregate)
-		provider->aggregate(node, 0, node->init_avg, node->init_peak,
-				    &node->avg_bw, &node->peak_bw);
+	if (node->avg_bw || node->peak_bw) {
+		if (provider->pre_aggregate)
+			provider->pre_aggregate(node);
+
+		if (provider->aggregate)
+			provider->aggregate(node, 0, node->init_avg, node->init_peak,
+					    &node->avg_bw, &node->peak_bw);
+		if (provider->set)
+			provider->set(node, node);
+	}
 
-	provider->set(node, node);
 	node->avg_bw = 0;
 	node->peak_bw = 0;
 
-- 
2.7.4


             reply	other threads:[~2023-01-13 22:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 22:07 Vivek Aknurwar [this message]
2023-01-14  1:24 ` [PATCH] interconnect: Skip call into provider if initial bw is zero Bryan O'Donoghue
2023-01-14  1:40   ` Bryan O'Donoghue
2023-01-19 22:18     ` Vivek Aknurwar
2023-01-19 23:56       ` Bryan O'Donoghue
2023-01-23 20:37         ` Mike Tipton
2023-01-23 22:58           ` Bryan O'Donoghue
2023-01-30 14:53             ` Abel Vesa
2023-01-30 21:55               ` Mike Tipton
2023-02-12 10:56               ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1673647679-15216-1-git-send-email-quic_viveka@quicinc.com \
    --to=quic_viveka@quicinc.com \
    --cc=djakov@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_mdtipton@quicinc.com \
    --cc=quic_okukatla@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox