Re: [PATCH v2 1/8] dt-bindings: PCI: Add binding for qps615

Krishna Chaitanya Chundru
2024-08-05T04:03:16Z

On 8/4/2024 2:26 PM, Krzysztof Kozlowski wrote:
> On 03/08/2024 05:22, Krishna chaitanya chundru wrote:
>> Add binding describing the Qualcomm PCIe switch, QPS615,
>> which provides Ethernet MAC integrated to the 3rd downstream port
>> and two downstream PCIe ports.
>>
>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>> ---
>> .../devicetree/bindings/pci/qcom,qps615.yaml | 191 +++++++++++++++++++++
>> 1 file changed, 191 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,qps615.yaml b/Documentation/devicetree/bindings/pci/qcom,qps615.yaml
>> new file mode 100644
>> index 000000000000..ea0c953ee56f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pci/qcom,qps615.yaml
>> @@ -0,0 +1,191 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pci/qcom,qps615.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm QPS615 PCIe switch
>> +
>> +maintainers:
>> + - Krishna chaitanya chundru <quic_krichai@quicinc.com>
>> +
>> +description: |
>> + Qualcomm QPS615 PCIe switch has one upstream and three downstream
>> + ports. The 3rd downstream port has integrated endpoint device of
>> + Ethernet MAC. Other two downstream ports are supposed to connect
>> + to external device.
>> +
>> + The QPS615 PCIe switch can be configured through I2C interface before
>> + PCIe link is established to change FTS, ASPM related entry delays,
>> + tx amplitude etc for better power efficiency and functionality.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - pci1179,0623
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + qcom,qps615-controller:
>
> and now I see that you totally ignored comments. Repeating the same over
> and over is a waste of time.
>
>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
>
> Thank you.
>
>
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,

In patch1 we are trying to add reference of i2c-adapter, you suggested
to use i2c-bus for that. we got comments on the driver code not to use
adapter and instead use i2c client reference. I felt i2c-bus is not
ideal to represent i2c client device so used this name.

I should have mentioned all these details in the change log for all
these changes. Next time onwards I will give detailed change log for
the changes between two versions.

- Krishna Chaitanya.