From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971CFC7EE39 for ; Sat, 27 May 2023 01:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230466AbjE0BD6 (ORCPT ); Fri, 26 May 2023 21:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238025AbjE0BDz (ORCPT ); Fri, 26 May 2023 21:03:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24A9B19A; Fri, 26 May 2023 18:03:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F20A1654C9; Sat, 27 May 2023 01:03:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53C1FC4339B; Sat, 27 May 2023 01:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685149433; bh=fxYWXexHjqMsOELaFczQ5u72qTfpRnCt7eHfSifnC2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yuykaj5RKxbCSk+uxlKl2m0aQPZGNjZDtnLBMcy4KjHfVAqu0H7uYggJT5era2Cpo u8lGXsajJdyjLbM9EIe79pWN3GhgB3jCyet4S6/rpRe0ZUcgdFEKl325VfpxqDncBh VfYe64xLlAoQQyl3hhaO99ys4mg1l1d9VGsWLolsMwgFVz+1ZkMwFP91dOaRMmgYiF yHLp9prljwstX/eaDUccOj3hKZ+uk0qFsE86Dho4buEJ7SnigRJjt3iRjCeHRxls51 pUMH3l5jYhQDxA2efs69Li/jEZT+0YK1xfpTkbl9mn+IRqJZJwqcqms5VBs+WmRs6F 0DgVp9tjMaiBw== From: Bjorn Andersson To: Rob Herring , Dan Murphy , Yassine Oudjana , Luca Weiss , phone-devel@vger.kernel.org, Konrad Dybcio , Raffaele Tranquillini , Andy Gross , Dmitry Torokhov , ~postmarketos/upstreaming@lists.sr.ht, Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: (subset) [PATCH 0/5] Improvements for drv260x driver and add to Huawei Watch Date: Fri, 26 May 2023 18:07:28 -0700 Message-Id: <168514964951.348612.17473479796367169535.b4-ty@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230430-drv260x-improvements-v1-0-1fb28b4cc698@z3ntu.xyz> References: <20230430-drv260x-improvements-v1-0-1fb28b4cc698@z3ntu.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, 30 Apr 2023 20:20:52 +0200, Luca Weiss wrote: > Clean up some issues with the driver I've noticed while working on it, > then fix the magnitude handling which previously resulted the driver > discarding the upper 8 bits of the magnitude value, and finally we can > add the drv260x to the APQ8026 Huawei Watch. > > While the "fix magnitude handling" commit technically changes behavior > and could change behavior of existing user space applications that deal > with this quirky behavior, it's definitely not correct and results in > very unexpected behavior if the user space doesn't look out for it > (meaning only use 0x00-0xFF magnitude, and also know that the magnitude > was interpreted as signed value, see more details in the commit message > there). > > [...] Applied, thanks! [5/5] ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator commit: ad318f9ce5a2e815816bfcf7f187a3ac32905523 Best regards, -- Bjorn Andersson