Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>
Cc: quic_tdas@quicinc.com, agross@kernel.org,
	linux-kernel@vger.kernel.org, kernel@quicinc.com,
	konrad.dybcio@linaro.org, andersson@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, djakov@kernel.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	quic_kaushalk@quicinc.com, quic_tingweiz@quicinc.com,
	quic_shashim@quicinc.com, quic_aiquny@quicinc.com,
	linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	conor+dt@kernel.org, quic_tsoni@quicinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm SM4450
Date: Thu, 14 Sep 2023 22:13:07 -0500	[thread overview]
Message-ID: <169474758717.2399747.7717873447401503497.robh@kernel.org> (raw)
In-Reply-To: <20230915020129.19611-2-quic_tengfan@quicinc.com>


On Fri, 15 Sep 2023 10:01:28 +0800, Tengfei Fan wrote:
> The Qualcomm SM4450 SoC has several bus fabrics that could be controlled
> and tuned dynamically according to the bandwidth demand.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  .../interconnect/qcom,sm4450-rpmh.yaml        | 133 ++++++++++++++
>  .../dt-bindings/interconnect/qcom,sm4450.h    | 163 ++++++++++++++++++
>  2 files changed, 296 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.yaml
>  create mode 100644 include/dt-bindings/interconnect/qcom,sm4450.h
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dts:18:18: fatal error: dt-bindings/clock/qcom,sm4450-gcc.h: No such file or directory
   18 |         #include <dt-bindings/clock/qcom,sm4450-gcc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230915020129.19611-2-quic_tengfan@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2023-09-15  3:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  2:01 [PATCH v2 0/2] interconnect: qcom: Add SM4450 interconnect Tengfei Fan
2023-09-15  2:01 ` [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm SM4450 Tengfei Fan
2023-09-15  3:13   ` Rob Herring [this message]
2023-09-15  7:17   ` Krzysztof Kozlowski
2023-09-15  7:26     ` Tengfei Fan
2023-09-15  2:01 ` [PATCH v2 2/2] interconnect: qcom: Add SM4450 interconnect provider driver Tengfei Fan
2023-09-15 12:43   ` Konrad Dybcio
2023-09-19  1:59     ` Tengfei Fan
2023-09-20 10:31       ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169474758717.2399747.7717873447401503497.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_aiquny@quicinc.com \
    --cc=quic_kaushalk@quicinc.com \
    --cc=quic_shashim@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=quic_tengfan@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox