From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: quic_narepall@quicinc.com, bmasney@redhat.com,
krzysztof.kozlowski+dt@linaro.org, quic_nitirawa@quicinc.com,
vireshk@kernel.org, quic_asutoshd@quicinc.com,
quic_bhaskarv@quicinc.com, avri.altman@wdc.com,
krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
robh+dt@kernel.org, quic_cang@quicinc.com,
quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com,
jejb@linux.ibm.com, cw00.choi@samsung.com, andersson@kernel.org,
bvanassche@acm.org, conor+dt@kernel.org,
kyungmin.park@samsung.com, martin.petersen@oracle.com, nm@ti.com,
linux-kernel@vger.kernel.org, quic_richardp@quicinc.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-scsi@vger.kernel.org, myungjoo.ham@samsung.com,
konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org,
sboyd@kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: ufs: common: add OPP table
Date: Tue, 03 Oct 2023 07:16:35 -0500 [thread overview]
Message-ID: <169633539510.282606.1450427416869008072.robh@kernel.org> (raw)
In-Reply-To: <20231003111232.42663-2-manivannan.sadhasivam@linaro.org>
On Tue, 03 Oct 2023 16:42:27 +0530, Manivannan Sadhasivam wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Except scaling UFS and bus clocks, it's necessary to scale also the
> voltages of regulators or power domain performance state levels. Adding
> Operating Performance Points table allows to adjust power domain
> performance state, depending on the UFS clock speed.
>
> OPPv2 deprecates previous property limited to clock scaling:
> freq-table-hz.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/ufs/ufs-common.yaml | 36 ++++++++++++++++---
> 1 file changed, 32 insertions(+), 4 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/ufs/ufs-common.yaml:90:20: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/ufs/ufs-common.yaml:91:26: [error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/ufs/ufs-common.yaml:91:36: [error] string value is redundantly quoted with any quotes (quoted-strings)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231003111232.42663-2-manivannan.sadhasivam@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-10-03 12:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 11:12 [PATCH v4 0/6] UFS: Add OPP support Manivannan Sadhasivam
2023-10-03 11:12 ` [PATCH v4 1/6] dt-bindings: ufs: common: add OPP table Manivannan Sadhasivam
2023-10-03 12:16 ` Rob Herring [this message]
2023-10-03 12:44 ` Manivannan Sadhasivam
2023-10-03 11:12 ` [PATCH v4 2/6] PM / devfreq: Switch to dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs Manivannan Sadhasivam
2023-10-06 15:24 ` Chanwoo Choi
2023-10-03 11:12 ` [PATCH v4 3/6] scsi: ufs: core: Add OPP support for scaling clocks and regulators Manivannan Sadhasivam
2023-10-03 11:12 ` [PATCH v4 4/6] scsi: ufs: host: Add support for parsing OPP Manivannan Sadhasivam
2023-10-03 11:12 ` [PATCH v4 5/6] arm64: dts: qcom: sdm845: Add OPP table support to UFSHC Manivannan Sadhasivam
2023-10-03 11:12 ` [PATCH v4 6/6] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-10-03 15:25 ` Dmitry Baryshkov
2023-10-04 6:25 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169633539510.282606.1450427416869008072.robh@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bmasney@redhat.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox