From: Bjorn Andersson <andersson@kernel.org>
To: "Andy Gross" <agross@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] clk: qcom: cbf-msm8996: Convert to platform remove callback returning void
Date: Sat, 21 Oct 2023 08:58:35 -0700 [thread overview]
Message-ID: <169790390705.1690547.7623433071492517440.b4-ty@kernel.org> (raw)
In-Reply-To: <20230911151548.672485-1-u.kleine-koenig@pengutronix.de>
On Mon, 11 Sep 2023 17:15:48 +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> [...]
Applied, thanks!
[1/1] clk: qcom: cbf-msm8996: Convert to platform remove callback returning void
commit: abaf59c470a7c9c59bda8da3517ec2ff0513f5a6
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2023-10-21 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:15 [PATCH] clk: qcom: cbf-msm8996: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-11 20:02 ` Stephen Boyd
2023-09-12 6:53 ` Uwe Kleine-König
2023-09-20 17:29 ` Bjorn Andersson
2023-10-10 3:49 ` Stephen Boyd
2023-10-20 15:50 ` Uwe Kleine-König
2023-10-21 15:58 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169790390705.1690547.7623433071492517440.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox