* [PATCH v2] media: venus: hfi: explicitly release IRQ during teardown
@ 2025-06-19 7:48 Jorge Ramirez-Ortiz
2025-06-19 8:06 ` Bryan O'Donoghue
2025-06-19 18:11 ` Dikshita Agarwal
0 siblings, 2 replies; 3+ messages in thread
From: Jorge Ramirez-Ortiz @ 2025-06-19 7:48 UTC (permalink / raw)
To: jorge.ramirez, quic_vgarodia, quic_dikshita, bryan.odonoghue,
mchehab
Cc: linux-media, linux-arm-msm, linux-kernel
Ensure the IRQ is disabled - and all pending handlers completed - before
dismantling the interrupt routing and clearing related pointers.
This prevents any possibility of the interrupt triggering after the
handler context has been invalidated.
Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
---
v2:
disable the handler and block until complete.
allow devres to release and free the allocated irq
drivers/media/platform/qcom/venus/hfi_venus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
index b5f2ea879950..ed003adb0282 100644
--- a/drivers/media/platform/qcom/venus/hfi_venus.c
+++ b/drivers/media/platform/qcom/venus/hfi_venus.c
@@ -1678,6 +1678,7 @@ void venus_hfi_destroy(struct venus_core *core)
venus_interface_queues_release(hdev);
mutex_destroy(&hdev->lock);
kfree(hdev);
+ disable_irq(core->irq);
core->ops = NULL;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: venus: hfi: explicitly release IRQ during teardown
2025-06-19 7:48 [PATCH v2] media: venus: hfi: explicitly release IRQ during teardown Jorge Ramirez-Ortiz
@ 2025-06-19 8:06 ` Bryan O'Donoghue
2025-06-19 18:11 ` Dikshita Agarwal
1 sibling, 0 replies; 3+ messages in thread
From: Bryan O'Donoghue @ 2025-06-19 8:06 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz, quic_vgarodia, quic_dikshita, mchehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 19/06/2025 08:48, Jorge Ramirez-Ortiz wrote:
> Ensure the IRQ is disabled - and all pending handlers completed - before
> dismantling the interrupt routing and clearing related pointers.
>
> This prevents any possibility of the interrupt triggering after the
> handler context has been invalidated.
>
> Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> ---
>
> v2:
> disable the handler and block until complete.
> allow devres to release and free the allocated irq
>
> drivers/media/platform/qcom/venus/hfi_venus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
> index b5f2ea879950..ed003adb0282 100644
> --- a/drivers/media/platform/qcom/venus/hfi_venus.c
> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c
> @@ -1678,6 +1678,7 @@ void venus_hfi_destroy(struct venus_core *core)
> venus_interface_queues_release(hdev);
> mutex_destroy(&hdev->lock);
> kfree(hdev);
> + disable_irq(core->irq);
> core->ops = NULL;
> }
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: venus: hfi: explicitly release IRQ during teardown
2025-06-19 7:48 [PATCH v2] media: venus: hfi: explicitly release IRQ during teardown Jorge Ramirez-Ortiz
2025-06-19 8:06 ` Bryan O'Donoghue
@ 2025-06-19 18:11 ` Dikshita Agarwal
1 sibling, 0 replies; 3+ messages in thread
From: Dikshita Agarwal @ 2025-06-19 18:11 UTC (permalink / raw)
To: Jorge Ramirez-Ortiz, quic_vgarodia, bryan.odonoghue, mchehab
Cc: linux-media, linux-arm-msm, linux-kernel
On 6/19/2025 1:18 PM, Jorge Ramirez-Ortiz wrote:
> Ensure the IRQ is disabled - and all pending handlers completed - before
> dismantling the interrupt routing and clearing related pointers.
>
> This prevents any possibility of the interrupt triggering after the
> handler context has been invalidated.
>
> Fixes: d96d3f30c0f2 ("[media] media: venus: hfi: add Venus HFI files")
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> ---
>
> v2:
> disable the handler and block until complete.
> allow devres to release and free the allocated irq
>
> drivers/media/platform/qcom/venus/hfi_venus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
> index b5f2ea879950..ed003adb0282 100644
> --- a/drivers/media/platform/qcom/venus/hfi_venus.c
> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c
> @@ -1678,6 +1678,7 @@ void venus_hfi_destroy(struct venus_core *core)
> venus_interface_queues_release(hdev);
> mutex_destroy(&hdev->lock);
> kfree(hdev);
> + disable_irq(core->irq);
> core->ops = NULL;
> }
>
Reviewed-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Tested-by: Dikshita Agarwal <quic_dikshita@quicinc.com> # RB5
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-19 18:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-19 7:48 [PATCH v2] media: venus: hfi: explicitly release IRQ during teardown Jorge Ramirez-Ortiz
2025-06-19 8:06 ` Bryan O'Donoghue
2025-06-19 18:11 ` Dikshita Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).