From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95EA019D07A; Tue, 27 May 2025 11:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748347131; cv=none; b=JdDQMjS37XcBHx9xkvUKHL37+dsBBgK7DmQmpIGx/duQ7NvXEI51vKtTtMQdZq4EkbqQS0BGiObJstpPOfVPyytzBfthAYLN1+ohobMlEXUZqOitTsqTx4dFoqaoUVQP0hUjFo1GK62C14CSsh2A8Sn5RM4h/iPrPr6kSeo1d3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748347131; c=relaxed/simple; bh=YWJSryJrQdHjv1Ca60lx+CUPrssSuwMmF117snckU4s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hIhG487QkeztsCzsEBycaYEbHIjXDdmTtkNsLDVa1HHqmLqZVyvmRqYIN6jbI9FSYLWN+U5zwiCOe9hiHyzO2oM0wxJr9rstkEGfNKQAYxRh9l/P32qfGvkz4XUpDmoHXRqOndv+OJFpMnb2Kf6DtA1cr0plORxkbx2UHKorVY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CIn/Pteu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CIn/Pteu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBAEBC4CEE9; Tue, 27 May 2025 11:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748347131; bh=YWJSryJrQdHjv1Ca60lx+CUPrssSuwMmF117snckU4s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CIn/PteuSjg9sRCPwiTXigvdG2ytCRBU145dRFQS8Jbs5hS2Ial1rrryFJnLd1Cd9 k3qWGzCYQ7NxN+jM19BBPrjKZ5WMvJ69sYwkD/rwax2flFBjwlRmyv5K1FwhSkzG1v jBg4YkHl7nUQ64sgazda5825IZ7+u2EXu9h0dc/B6uTZf0/I3nNwo0AnFNOu7HjbYZ 8lLPFhu4iMBel1BVL7n0oX/g2LUQe8ONa4kkuNj1H7op+Y+FaaNs/Ne+0yE683b7k5 a0oDQhNuj+N/4xZZEzhyd0XPYejuVOaT/zWgoGxAulaFoEZPj6c40fGT7j5ZOjHTMa 1TUJEWXPcXhqw== Message-ID: <171b980d-9c50-4891-86dc-e30d712f5384@kernel.org> Date: Tue, 27 May 2025 13:58:44 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution To: Prasad Kumpatla , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, kernel@oss.qualcomm.com, Mohammad Rafi Shaik References: <20250527111227.2318021-1-quic_pkumpatl@quicinc.com> <20250527111227.2318021-3-quic_pkumpatl@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250527111227.2318021-3-quic_pkumpatl@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/05/2025 13:12, Prasad Kumpatla wrote: > From: Mohammad Rafi Shaik > > Manage clock settings for ADSP solution and document the clock properties > on sc7280 lpass pincontrol node which is required for ADSP based > solution. > > Signed-off-by: Mohammad Rafi Shaik > Co-developed-by: Prasad Kumpatla > Signed-off-by: Prasad Kumpatla > --- Nothing in cover letter explained what was happening with this patch. Provide changelog under --- in such case. > .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 10 ++++++++ > .../bindings/sound/qcom,lpass-va-macro.yaml | 12 +++++++--- > .../bindings/sound/qcom,lpass-wsa-macro.yaml | 24 ++++++++++++++++--- Split patches per subsystem. Pinctrl is not ASoC. > 3 files changed, 40 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml > index 08801cc4e476..b1270124bfe3 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml > @@ -20,6 +20,16 @@ properties: > reg: > maxItems: 2 > > + clocks: > + items: > + - description: LPASS Core voting clock > + - description: LPASS Audio voting clock > + > + clock-names: > + items: > + - const: core > + - const: audio > + > patternProperties: > "-state$": > oneOf: > diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > index f41deaa6f4df..92b97c214060 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml > @@ -78,10 +78,16 @@ allOf: > then: > properties: > clocks: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > clock-names: > - items: > - - const: mclk > + oneOf: > + - items: # for ADSP based platforms > + - const: mclk > + - const: macro > + - const: dcodec > + - items: # for ADSP bypass based platforms > + - const: mclk This device always receives same amount of clocks. Hardware is not different if you decide to not use ADSP. > > - if: > properties: > diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml > index 9082e363c709..6a999ed484e7 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml > @@ -35,11 +35,11 @@ properties: > const: 0 > > clocks: > - minItems: 4 > + minItems: 3 > maxItems: 6 > > clock-names: > - minItems: 4 > + minItems: 3 > maxItems: 6 > > clock-output-names: > @@ -59,12 +59,30 @@ required: > > allOf: > - $ref: dai-common.yaml# > - > - if: > properties: > compatible: > enum: > - qcom,sc7280-lpass-wsa-macro > + then: > + properties: > + clock-names: > + oneOf: > + - items: # for ADSP based platforms > + - const: mclk > + - const: npl > + - const: macro > + - const: dcodec > + - const: fsgen > + - items: # for ADSP bypass based platforms > + - const: mclk > + - const: npl > + - const: fsgen This silently breaks ABI. Third clock is macro. Best regards, Krzysztof