Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Mahadevan <quic_mahap@quicinc.com>
Cc: danila@jiaxyga.com, andersson@kernel.org,
	quic_jesszhan@quicinc.com,  linux-arm-msm@vger.kernel.org,
	krzk+dt@kernel.org, daniel@ffwll.ch,  neil.armstrong@linaro.org,
	dri-devel@lists.freedesktop.org,  quic_vpolimer@quicinc.com,
	conor+dt@kernel.org, tzimmermann@suse.de,
	 devicetree@vger.kernel.org, maarten.lankhorst@linux.intel.com,
	 robdclark@gmail.com, quic_jmadiset@quicinc.com,
	swboyd@chromium.org,  konrad.dybcio@linaro.org,
	mripard@kernel.org, sean@poorly.run,
	 dmitry.baryshkov@linaro.org, bigfoot@classfun.cn,
	airlied@gmail.com,  linux-kernel@vger.kernel.org,
	marijn.suijten@somainline.org,  quic_abhinavk@quicinc.com,
	freedreno@lists.freedesktop.org,  mailingradian@gmail.com,
	quic_kalyant@quicinc.com
Subject: Re: [PATCH v2 1/5] dt-bindings: display/msm: Document MDSS on SA8775P
Date: Thu, 26 Sep 2024 08:01:23 -0500	[thread overview]
Message-ID: <172735568239.2508021.3963412517463668613.robh@kernel.org> (raw)
In-Reply-To: <20240926110137.2200158-2-quic_mahap@quicinc.com>


On Thu, 26 Sep 2024 16:31:33 +0530, Mahadevan wrote:
> Document the MDSS hardware found on the Qualcomm SA8775P platform.
> 
> Signed-off-by: Mahadevan <quic_mahap@quicinc.com>
> ---
> 
> [v2]
> - Use fake DISPCC nodes to avoid clock dependencies in dt-bindings. [Dmitry]
> - Update bindings by fixing dt_binding_check tool errors (update includes in example),
>   adding proper spacing and indentation in binding example, dropping unused labels,
>   dropping status disable, adding reset node. [Dmitry, Rob, Krzysztof]
> 
> ---
>  .../display/msm/qcom,sa8775p-mdss.yaml        | 239 ++++++++++++++++++
>  1 file changed, 239 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml: ^display-controller@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml: ^displayport-controller@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint
Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dts:61.13-20: Warning (ranges_format): /example-0/display-subsystem@ae00000:ranges: empty "ranges" property but its #address-cells (2) differs from /example-0 (1)
Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dts:61.13-20: Warning (ranges_format): /example-0/display-subsystem@ae00000:ranges: empty "ranges" property but its #size-cells (2) differs from /example-0 (1)
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: display-subsystem@ae00000: reg: [[0, 182452224], [0, 4096]] is too long
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,sa8775p-mdss.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.example.dtb: display-subsystem@ae00000: Unevaluated properties are not allowed ('reg' was unexpected)
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,sa8775p-mdss.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240926110137.2200158-2-quic_mahap@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-09-26 13:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26 11:01 [PATCH v2 0/5] Display enablement changes for Qualcomm SA8775P platform Mahadevan
2024-09-26 11:01 ` [PATCH v2 1/5] dt-bindings: display/msm: Document MDSS on SA8775P Mahadevan
2024-09-26 12:59   ` Dmitry Baryshkov
2024-09-26 13:01   ` Rob Herring (Arm) [this message]
2024-09-26 13:24   ` Bjorn Andersson
2024-09-30  9:01     ` Mahadevan P
2024-09-26 13:46   ` Krzysztof Kozlowski
2024-09-26 11:01 ` [PATCH v2 2/5] dt-bindings: display/msm: Document the DPU for SA8775P Mahadevan
2024-09-26 13:00   ` Dmitry Baryshkov
2024-09-26 13:01   ` Rob Herring (Arm)
2024-09-26 13:47   ` Krzysztof Kozlowski
2024-09-26 11:01 ` [PATCH v2 3/5] drm/msm: mdss: Add SA8775P support Mahadevan
2024-09-26 13:02   ` Dmitry Baryshkov
2024-09-27  6:44     ` Mahadevan P
2024-09-27  8:42       ` Dmitry Baryshkov
2024-09-26 11:01 ` [PATCH v2 4/5] drm/msm/dpu: " Mahadevan
2024-09-26 13:09   ` Dmitry Baryshkov
2024-09-30 15:41     ` Mahadevan P
2024-09-26 11:01 ` [PATCH v2 5/5] arm64: dts: qcom: sa8775p: add display dt nodes Mahadevan
2024-09-26 13:12   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172735568239.2508021.3963412517463668613.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=bigfoot@classfun.cn \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=danila@jiaxyga.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mailingradian@gmail.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=quic_jmadiset@quicinc.com \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_mahap@quicinc.com \
    --cc=quic_vpolimer@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox