From: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>,
Mukesh Ojha <quic_mojha@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Stephan Gerhold <stephan.gerhold@linaro.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Kuldeep Singh <quic_kuldsing@quicinc.com>,
Elliot Berman <quic_eberman@quicinc.com>,
Andrew Halaney <ahalaney@redhat.com>,
Avaneesh Kumar Dwivedi <quic_akdwived@quicinc.com>,
Andy Gross <andy.gross@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: (subset) [PATCH v2 0/6] firmware: qcom: scm: Fixes for concurrency
Date: Tue, 7 Jan 2025 10:38:38 -0600 [thread overview]
Message-ID: <173626793412.69400.280273559890733366.b4-ty@kernel.org> (raw)
In-Reply-To: <20241209-qcom-scm-missing-barriers-and-all-sort-of-srap-v2-0-9061013c8d92@linaro.org>
On Mon, 09 Dec 2024 15:27:53 +0100, Krzysztof Kozlowski wrote:
> Changes in v2:
> - Patch #2: Extend commit msg
> - Patch #4: Store NULL
> - Add Rb tags
> - Link to v1: https://lore.kernel.org/r/20241119-qcom-scm-missing-barriers-and-all-sort-of-srap-v1-0-7056127007a7@linaro.org
>
> Description
> ===========
> SCM driver looks messy in terms of handling concurrency of probe. The
> driver exports interface which is guarded by global '__scm' variable
> but:
> 1. Lacks proper read barrier (commit adding write barriers mixed up
> READ_ONCE with a read barrier).
> 2. Lacks barriers or checks for '__scm' in multiple places.
> 3. Lacks probe error cleanup.
>
> [...]
Applied, thanks!
[1/6] firmware: qcom: scm: Fix missing read barrier in qcom_scm_is_available()
commit: 0a744cceebd0480cb39587b3b1339d66a9d14063
[2/6] firmware: qcom: scm: Fix missing read barrier in qcom_scm_get_tzmem_pool()
commit: b628510397b5cafa1f5d3e848a28affd1c635302
[4/6] firmware: qcom: scm: Cleanup global '__scm' on probe failures
commit: 1e76b546e6fca7eb568161f408133904ca6bcf4f
[5/6] firmware: qcom: scm: smc: Handle missing SCM device
commit: 94f48ecf0a538019ca2025e0b0da391f8e7cc58c
[6/6] firmware: qcom: scm: smc: Narrow 'mempool' variable scope
commit: a4332f6c791e1d70bf025ac51afa968607b9812b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2025-01-07 16:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 14:27 [PATCH v2 0/6] firmware: qcom: scm: Fixes for concurrency Krzysztof Kozlowski
2024-12-09 14:27 ` [PATCH v2 1/6] firmware: qcom: scm: Fix missing read barrier in qcom_scm_is_available() Krzysztof Kozlowski
2024-12-09 14:27 ` [PATCH v2 2/6] firmware: qcom: scm: Fix missing read barrier in qcom_scm_get_tzmem_pool() Krzysztof Kozlowski
2024-12-09 14:27 ` [PATCH v2 3/6] firmware: qcom: scm: Handle various probe ordering for qcom_scm_assign_mem() Krzysztof Kozlowski
2024-12-09 20:25 ` Bartosz Golaszewski
2025-01-07 0:42 ` Bjorn Andersson
2025-01-08 11:12 ` Krzysztof Kozlowski
2024-12-09 14:27 ` [PATCH v2 4/6] firmware: qcom: scm: Cleanup global '__scm' on probe failures Krzysztof Kozlowski
2024-12-09 14:27 ` [PATCH v2 5/6] firmware: qcom: scm: smc: Handle missing SCM device Krzysztof Kozlowski
2024-12-09 15:14 ` Bartosz Golaszewski
2024-12-09 14:27 ` [PATCH v2 6/6] firmware: qcom: scm: smc: Narrow 'mempool' variable scope Krzysztof Kozlowski
2025-01-07 16:38 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173626793412.69400.280273559890733366.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andy.gross@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_akdwived@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_kuldsing@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=stephan.gerhold@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox