Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
Cc: rui.zhang@intel.com, lee@kernel.org, agross@kernel.org,
	 konradybcio@kernel.org, cros-qcom-dts-watchers@chromium.org,
	 conor+dt@kernel.org, anjelique.melendez@oss.qualcomm.com,
	 david.collins@oss.qualcomm.com, quic_kamalw@quicinc.com,
	 lukasz.luba@arm.com, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org,  lars@metafoo.de,
	linux-iio@vger.kernel.org, amitk@kernel.org,
	 linux-arm-msm@vger.kernel.org, daniel.lezcano@linaro.org,
	jic23@kernel.org,  sboyd@kernel.org, krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org,  rafael@kernel.org,
	linux-pm@vger.kernel.org, thara.gopinath@gmail.com,
	 andersson@kernel.org, quic_skakitap@quicinc.com,
	 dmitry.baryshkov@linaro.org,
	subbaraman.narayanamurthy@oss.qualcomm.com
Subject: Re: [PATCH V5 2/5] dt-bindings: iio: adc: Split out QCOM VADC channel properties
Date: Fri, 31 Jan 2025 13:41:59 -0600	[thread overview]
Message-ID: <173835251554.3936459.14441041624354472103.robh@kernel.org> (raw)
In-Reply-To: <20250131183242.3653595-3-jishnu.prakash@oss.qualcomm.com>


On Sat, 01 Feb 2025 00:02:39 +0530, Jishnu Prakash wrote:
> Split out the common channel properties for QCOM VADC devices into a
> separate file so that it can be included as a reference for devices
> using them. This will be needed for the upcoming ADC5 Gen3 binding
> support patch, as ADC5 Gen3 also uses all of these common properties.
> 
> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> ---
>  .../iio/adc/qcom,spmi-vadc-common.yaml        | 87 +++++++++++++++++++
>  .../bindings/iio/adc/qcom,spmi-vadc.yaml      | 75 +---------------
>  2 files changed, 89 insertions(+), 73 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc-common.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.example.dts:88:18: fatal error: dt-bindings/iio/adc/qcom,spmi-vadc.h: No such file or directory
   88 |         #include <dt-bindings/iio/adc/qcom,spmi-vadc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.example.dtb] Error 1

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250131183242.3653595-3-jishnu.prakash@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-01-31 19:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-31 18:32 [PATCH V5 0/5] Add support for QCOM SPMI PMIC5 Gen3 ADC Jishnu Prakash
2025-01-31 18:32 ` [PATCH V5 1/5] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder Jishnu Prakash
2025-01-31 19:41   ` Rob Herring (Arm)
2025-02-02 13:29   ` Krzysztof Kozlowski
2025-02-26  8:51     ` Jishnu Prakash
2025-02-26  9:11       ` Krzysztof Kozlowski
2025-03-03 13:56         ` Jishnu Prakash
2025-03-10 14:19           ` Jishnu Prakash
2025-01-31 18:32 ` [PATCH V5 2/5] dt-bindings: iio: adc: Split out QCOM VADC channel properties Jishnu Prakash
2025-01-31 19:41   ` Rob Herring (Arm) [this message]
2025-02-02 13:32   ` Krzysztof Kozlowski
2025-01-31 18:32 ` [PATCH V5 3/5] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC Jishnu Prakash
2025-01-31 19:42   ` Rob Herring (Arm)
2025-02-01 11:33   ` Jonathan Cameron
2025-02-26  8:51     ` Jishnu Prakash
2025-02-02 13:38   ` Krzysztof Kozlowski
2025-02-26  8:51     ` Jishnu Prakash
2025-02-26  9:42       ` Krzysztof Kozlowski
2025-01-31 18:32 ` [PATCH V5 4/5] " Jishnu Prakash
2025-02-01 10:06   ` kernel test robot
2025-02-01 12:11   ` Jonathan Cameron
2025-02-26  8:52     ` Jishnu Prakash
2025-03-01  3:25       ` Jonathan Cameron
2025-03-03 13:56         ` Jishnu Prakash
2025-03-04  0:09           ` Jonathan Cameron
2025-02-01 23:36   ` kernel test robot
2025-01-31 18:32 ` [PATCH V5 5/5] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring Jishnu Prakash
2025-02-01 12:27   ` Jonathan Cameron
2025-02-26  8:52     ` Jishnu Prakash
2025-03-01  3:29       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173835251554.3936459.14441041624354472103.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=anjelique.melendez@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=david.collins@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jic23@kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_kamalw@quicinc.com \
    --cc=quic_skakitap@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@kernel.org \
    --cc=subbaraman.narayanamurthy@oss.qualcomm.com \
    --cc=thara.gopinath@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox