From: "Rob Herring (Arm)" <robh@kernel.org>
To: Luca Weiss <luca@lucaweiss.eu>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Konrad Dybcio <konradybcio@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
devicetree@vger.kernel.org,
Adam Honse <calcprogrammer1@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
phone-devel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: msm8974-samsung-hlte: Add touchkey support
Date: Mon, 21 Apr 2025 10:07:34 -0500 [thread overview]
Message-ID: <174524752186.2425711.13225157448230184467.robh@kernel.org> (raw)
In-Reply-To: <20250419-hlte-touchkey-v1-1-9d93c3e2b31f@lucaweiss.eu>
On Sat, 19 Apr 2025 11:08:19 +0200, Luca Weiss wrote:
> From: Adam Honse <calcprogrammer1@gmail.com>
>
> Add support for the touchkeys on the Samsung Galaxy Note 3 (hlte).
>
> Signed-off-by: Adam Honse <calcprogrammer1@gmail.com>
> ---
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> .../boot/dts/qcom/qcom-msm8974-samsung-hlte.dts | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 8ffd015db85fea3e15a77027fda6c02ced4d2444
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/' for 20250419-hlte-touchkey-v1-1-9d93c3e2b31f@lucaweiss.eu:
arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: i2c-gpio-touchkey (i2c-gpio): $nodename:0: 'i2c-gpio-touchkey' does not match '^i2c(@.+|-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
arch/arm/boot/dts/qcom/qcom-msm8974-samsung-hlte.dtb: i2c-gpio-touchkey (i2c-gpio): Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'touchkey@20' were unexpected)
from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
next prev parent reply other threads:[~2025-04-21 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 9:08 [PATCH] ARM: dts: qcom: msm8974-samsung-hlte: Add touchkey support Luca Weiss
2025-04-19 9:32 ` Luca Weiss
2025-04-21 15:07 ` Rob Herring (Arm) [this message]
2025-04-22 19:43 ` Konrad Dybcio
2025-06-10 16:57 ` Luca Weiss
2025-06-10 18:57 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174524752186.2425711.13225157448230184467.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=calcprogrammer1@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox