Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Lijuan Gao <quic_lijuang@quicinc.com>
Cc: linux-kernel@vger.kernel.org,
	 Mathieu Poirier <mathieu.poirier@linaro.org>,
	linux-arm-msm@vger.kernel.org,
	 Kyle Deng <quic_chunkaid@quicinc.com>,
	Conor Dooley <conor+dt@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	linux-remoteproc@vger.kernel.org,  kernel@quicinc.com,
	 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org,
	 Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH 0/6] arm64: dts: qcom: qcs615: enable remoteprocs - ADSP and CDSP
Date: Wed, 23 Apr 2025 08:37:44 -0500	[thread overview]
Message-ID: <174541475836.315268.1404586813028809700.robh@kernel.org> (raw)
In-Reply-To: <20250423-add_qcs615_remoteproc_support-v1-0-a94fe8799f14@quicinc.com>


On Wed, 23 Apr 2025 17:17:36 +0800, Lijuan Gao wrote:
> Enable the remote processor PAS loader for QCS615 ADSP and CDSP
> processors. This allows different platforms/architectures to control
> (power on, load firmware, power off) those remote processors while
> abstracting the hardware differences. Additionally, and add a PIL region
> in IMEM so that post mortem debug tools can collect ramdumps.
> 
> Signed-off-by: Lijuan Gao <quic_lijuang@quicinc.com>
> ---
> Kyle Deng (1):
>       arm64: dts: qcom: qcs615: Add mproc node for SEMP2P
> 
> Lijuan Gao (5):
>       dt-bindings: remoteproc: qcom,sm8150-pas: Document QCS615 remoteproc
>       dt-bindings: soc: qcom: add qcom,qcs615-imem compatible
>       arm64: dts: qcom: qcs615: Add IMEM and PIL info region
>       arm64: dts: qcom: qcs615: add ADSP and CDSP nodes
>       arm64: dts: qcom: qcs615-ride: enable remoteprocs
> 
>  .../bindings/remoteproc/qcom,sm8150-pas.yaml       |  59 ++++---
>  .../devicetree/bindings/sram/qcom,imem.yaml        |   1 +
>  arch/arm64/boot/dts/qcom/qcs615-ride.dts           |  10 ++
>  arch/arm64/boot/dts/qcom/qcs615.dtsi               | 179 +++++++++++++++++++++
>  4 files changed, 225 insertions(+), 24 deletions(-)
> ---
> base-commit: f660850bc246fef15ba78c81f686860324396628
> change-id: 20250416-add_qcs615_remoteproc_support-61ddab556c4e
> 
> Best regards,
> --
> Lijuan Gao <quic_lijuang@quicinc.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit f660850bc246fef15ba78c81f686860324396628

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250423-add_qcs615_remoteproc_support-v1-0-a94fe8799f14@quicinc.com:

arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-adsp (qcom,smp2p): 'qcom,sleepstate-in', 'qcom,smp2p-rdbg2-in', 'qcom,smp2p-rdbg2-out', 'sleepstate-out' do not match any of the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-adsp (qcom,smp2p): {'compatible': ['qcom,smp2p'], 'qcom,smem': [443, 429], 'interrupts': [[0, 172, 1]], 'mboxes': [[30, 26]], 'qcom,ipc': [[31, 0, 26]], 'qcom,local-pid': 0, 'qcom,remote-pid': 2, 'master-kernel': {'qcom,entry-name': ['master-kernel'], '#qcom,smem-state-cells': 1, 'phandle': 218}, 'slave-kernel': {'qcom,entry-name': ['slave-kernel'], 'interrupt-controller': True, '#interrupt-cells': 2, 'phandle': 216}, 'sleepstate-out': {'qcom,entry-name': ['sleepstate'], '#qcom,smem-state-cells': 1}, 'qcom,sleepstate-in': {'qcom,entry-name': ['sleepstate_see'], 'interrupt-controller': True, '#interrupt-cells': 2}, 'qcom,smp2p-rdbg2-out': {'qcom,entry-name': ['rdbg'], '#qcom,smem-state-cells': 1}, 'qcom,smp2p-rdbg2-in': {'qcom,entry-name': ['rdbg'], 'interrupt-controller': True, '#interrupt-cells': 2}, '$nodename': ['qcom,smp2p-adsp']} is valid under each of {'required': ['qcom,ipc']}, {'required': ['mboxes']}
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-cdsp (qcom,smp2p): 'qcom,smp2p-rdbg5-in', 'qcom,smp2p-rdbg5-out' do not match any of the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-cdsp (qcom,smp2p): {'compatible': ['qcom,smp2p'], 'qcom,smem': [94, 432], 'interrupts': [[0, 576, 1]], 'mboxes': [[30, 6]], 'qcom,ipc': [[31, 0, 6]], 'qcom,local-pid': 0, 'qcom,remote-pid': 5, 'master-kernel': {'qcom,entry-name': ['master-kernel'], '#qcom,smem-state-cells': 1, 'phandle': 200}, 'slave-kernel': {'qcom,entry-name': ['slave-kernel'], 'interrupt-controller': True, '#interrupt-cells': 2, 'phandle': 198}, 'qcom,smp2p-rdbg5-out': {'qcom,entry-name': ['rdbg'], '#qcom,smem-state-cells': 1}, 'qcom,smp2p-rdbg5-in': {'qcom,entry-name': ['rdbg'], 'interrupt-controller': True, '#interrupt-cells': 2}, '$nodename': ['qcom,smp2p-cdsp']} is valid under each of {'required': ['qcom,ipc']}, {'required': ['mboxes']}
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-cdsp@8300000 (qcom,qcs615-cdsp-pas): interrupt-names:2: 'ready' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-cdsp@8300000 (qcom,qcs615-cdsp-pas): interrupt-names:3: 'handover' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-cdsp@8300000 (qcom,qcs615-cdsp-pas): Unevaluated properties are not allowed ('glink-edge', 'qcom,smem-state-names', 'qcom,smem-states' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: syscon@17c0000c (syscon): compatible: ['syscon'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-adsp@62400000 (qcom,qcs615-adsp-pas): interrupt-names:2: 'ready' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-adsp@62400000 (qcom,qcs615-adsp-pas): interrupt-names:3: 'handover' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-adsp@62400000 (qcom,qcs615-adsp-pas): Unevaluated properties are not allowed ('glink-edge', 'qcom,smem-state-names', 'qcom,smem-states' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#






  parent reply	other threads:[~2025-04-23 13:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  9:17 [PATCH 0/6] arm64: dts: qcom: qcs615: enable remoteprocs - ADSP and CDSP Lijuan Gao
2025-04-23  9:17 ` [PATCH 1/6] dt-bindings: remoteproc: qcom,sm8150-pas: Document QCS615 remoteproc Lijuan Gao
2025-04-28  7:48   ` Krzysztof Kozlowski
2025-04-23  9:17 ` [PATCH 2/6] dt-bindings: soc: qcom: add qcom,qcs615-imem compatible Lijuan Gao
2025-04-28  7:52   ` Krzysztof Kozlowski
2025-04-23  9:17 ` [PATCH 3/6] arm64: dts: qcom: qcs615: Add mproc node for SEMP2P Lijuan Gao
2025-04-23  9:29   ` Konrad Dybcio
2025-05-07  6:24     ` Lijuan Gao
2025-04-23  9:17 ` [PATCH 4/6] arm64: dts: qcom: qcs615: Add IMEM and PIL info region Lijuan Gao
2025-04-23  9:30   ` Konrad Dybcio
2025-04-23  9:17 ` [PATCH 5/6] arm64: dts: qcom: qcs615: add ADSP and CDSP nodes Lijuan Gao
2025-04-23  9:34   ` Konrad Dybcio
2025-04-24  7:56     ` Lijuan Gao
2025-04-26  9:54       ` Konrad Dybcio
2025-04-23  9:17 ` [PATCH 6/6] arm64: dts: qcom: qcs615-ride: enable remoteprocs Lijuan Gao
2025-04-23 13:40   ` Dmitry Baryshkov
2025-04-24  8:24     ` Lijuan Gao
2025-04-23 13:37 ` Rob Herring (Arm) [this message]
2025-04-24  8:05   ` [PATCH 0/6] arm64: dts: qcom: qcs615: enable remoteprocs - ADSP and CDSP Lijuan Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174541475836.315268.1404586813028809700.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=quic_chunkaid@quicinc.com \
    --cc=quic_lijuang@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox