[PATCH v2 0/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[PATCH v2 0/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Aleksandrs Vinarskis]

Follow up to previous discussion [1].

Disable camera specific PMIC pm8010 by default, as some X1E/X1 devices
do not have one. Platform that utilize it should enable it.

Affected upstream devices:
- none
Affected devices submitted upstream (did not land yet):
- CRD, as part of CAMSS series by Bryan [2]

Change in v2:
- Drop reference to power button issue on Dell XPS. The correlation
  between pm8010 erroring-out and power button not working cannot be
  reproduced anymore on kernel 6.14/6.16, Ubuntu 24.10/25.04, BIOS
  2.2.0/2.8.0. Perhaps was intermediate regression that was since
  resolved. Either way, appears to be irrelevant to this change now.
Link to v1: https://lore.kernel.org/all/20250624225056.1056974-1-alex.vinarskis@gmail.com/


[1] https://lore.kernel.org/linux-arm-msm/519f9e21-466f-4e8b-9bd0-dfe0448920bb@oss.qualcomm.com/
[2] https://lore.kernel.org/all/20250417-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-5-3fd4124cf35a@linaro.org/

Aleksandrs Vinarskis (1):
  arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

 arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.48.1

[PATCH v2 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Aleksandrs Vinarskis]

pm8010 is a camera specific PMIC, and may not be present on some
devices. These may instead use a dedicated vreg for this purpose (Dell
XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
alltogether (Lenovo Thinbook 16, Lenovo Yoga..).

Disable pm8010 by default, let platforms that actually have one onboard
enable it instead.

Cc: <stable@vger.kernel.org>
Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
 arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
index e3888bc143a0..621890ada153 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
@@ -475,6 +475,8 @@ pm8010: pmic@c {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		status = "disabled";
+
 		pm8010_temp_alarm: temp-alarm@2400 {
 			compatible = "qcom,spmi-temp-alarm";
 			reg = <0x2400>;
-- 
2.48.1

Re: [PATCH v2 1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Aleksandrs Vinarskis]

On Tue, 1 Jul 2025 at 20:36, Aleksandrs Vinarskis
<alex.vinarskis@gmail.com> wrote:
>
> pm8010 is a camera specific PMIC, and may not be present on some
> devices. These may instead use a dedicated vreg for this purpose (Dell
> XPS 9345, Dell Inspiron..) or use USB webcam instead of a MIPI one
> alltogether (Lenovo Thinbook 16, Lenovo Yoga..).
>
> Disable pm8010 by default, let platforms that actually have one onboard
> enable it instead.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 2559e61e7ef4 ("arm64: dts: qcom: x1e80100-pmics: Add the missing PMICs")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

Hi,

I've noticed this was reviewed some time ago, but was not included in
for upcoming 6.17. Perhaps it was forgotten?

Thanks in advance,
Alex

>  arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> index e3888bc143a0..621890ada153 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi
> @@ -475,6 +475,8 @@ pm8010: pmic@c {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>
> +               status = "disabled";
> +
>                 pm8010_temp_alarm: temp-alarm@2400 {
>                         compatible = "qcom,spmi-temp-alarm";
>                         reg = <0x2400>;
> --
> 2.48.1
>

Re: (subset) [PATCH v2 0/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default

[Bjorn Andersson]

On Tue, 01 Jul 2025 20:35:52 +0200, Aleksandrs Vinarskis wrote:
> Follow up to previous discussion [1].
> 
> Disable camera specific PMIC pm8010 by default, as some X1E/X1 devices
> do not have one. Platform that utilize it should enable it.
> 
> Affected upstream devices:
> - none
> Affected devices submitted upstream (did not land yet):
> - CRD, as part of CAMSS series by Bryan [2]
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: x1e80100-pmics: Disable pm8010 by default
      commit: b9a185198f96259311543b30d884d8c01da913f7

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>