Re: [PATCH v5 0/3] platform: arm64: thinkpad-t14s-ec: new driver

Ilpo Järvinen
2025-09-23T08:40:14Z

On Thu, 18 Sep 2025 23:20:25 +0200, Sebastian Reichel wrote:

> Introduce driver for the ThinkPad T14s Gen6 Snapdragon EC. In theory
> it seems to be compatible with the ThinkPad ACPI driver, but these
> devices are booted with device tree. As the name implies, the existing
> ThinkPad ACPI driver only supports the ACPI interface. Looking at
> the implementation, the ACPI DSDT contains many mapping functions
> to translate the low level I2C messages into the interface used by
> the ThinkPad ACPI driver. Adding DT support to the ThinkPad ACPI driver
> would require adding all those translation functions, which would add
> more or less the same amount of code as writing a separate driver using
> the low level interface directly. I don't think it's sensible to make
> the existing ACPI driver even more complicated, so I went for a separate
> driver.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/3] dt-bindings: platform: Add Lenovo Thinkpad T14s EC
commit: bee278e18e641a4bc11513b0fa8f5eb2667b8a32
[2/3] platform: arm64: thinkpad-t14s-ec: new driver
commit: 27221f91b83ff1435e550f57b8380a01bab0fc80
[3/3] arm64: dts: qcom: x1e80100-t14s: add EC
commit: 7de8353e082d179a241dc4a4129c5d6916803399

--
i.