Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: Add TSENS and QUPv3 serial engines

["Aiqun(Maria) Yu" <aiqun.yu@oss.qualcomm.com>]

On 12/29/2025 9:12 PM, Konrad Dybcio wrote:
> On 12/26/25 4:06 AM, Jingyi Wang wrote:
>> Add new features on the Kaanapali Platform including:
>>
>> - Temperature Sensor (TSENS) and thermal zones
>> - QUPv3 serial engine protocols with 5 I2C hubs and 24 QUP serial engines
>>   across 4 QUP wrappers, each with support of GPI DMA engines.
>>
>> Co-developed-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
>> Co-developed-by: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
>> Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@oss.qualcomm.com>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> ---
> 
> Since the base DT is now merged, all subsequent patches are
> supposed to be patch-sized, i.e. usually scoped for one feature that
> makes sense. This one happens to be an arbitrary concatenation of two
> separate ones. Were they separate, the original authors would benefit
> from the full attribution and they would be easier for us to review

Hi Konrad,

Are you suggesting to split this patch into 3 function independent
patches here?

The current dt series is to ease the maintainers' effort to have an
organized patch in one series in below manner:
1. And the series of the dt change will only have all dependency cleared
functionality in this series.
2. dt maintainer won't have any conflict when apply.
3. we will suggest developers can do it's own upload when basic
dependencies like mm-clock and pmic dependencies are all applied.

Are you suggesting splitting this patch into three independent
functional patches here?
The current DT series is designed to simplify maintainers’ efforts by
keeping the patches organized within a single series, structured as follows:

1. This DT series will include only functionality where all dependencies
have been reviewed-by at least.
2. DT maintainers will not encounter conflicts when applying these patches.
3. We will recommend that developers upload their own patches once the
basic dependencies—such as MM-clock and PMIC—have been applied.

This reflects our discussion with Bjorn and serves as a lesson learned:
even with a Reviewed-by tag, patch application can be significantly
delayed when the DT series involves a highly complex dependency chain.

> 
> Konrad

-- 
Thx and BRs,
Aiqun(Maria) Yu