From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: perex@perex.cz, tiwai@suse.com, srini@kernel.org,
alexey.klimov@linaro.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 0/4] ASoC: qcom: sdw: fix memory leak
Date: Thu, 30 Oct 2025 16:50:11 +0000 [thread overview]
Message-ID: <176184301177.119935.14003591741907115293.b4-ty@kernel.org> (raw)
In-Reply-To: <20251022143349.1081513-1-srinivas.kandagatla@oss.qualcomm.com>
On Wed, 22 Oct 2025 15:33:45 +0100, Srinivas Kandagatla wrote:
> For some reason we endedup allocating sdw_stream_runtime for every cpu dai,
> this has two issues.
> 1. we never set snd_soc_dai_set_stream for non soundwire dai, which
> means there is no way that we can free this, resulting in memory leak
> 2. startup and shutdown callbacks can be called without
> hw_params callback called. This combination results in memory leak
> because machine driver sruntime array pointer is only set in hw_params
> callback.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/4] ASoC: qcom: sdw: fix memory leak for sdw_stream_runtime
commit: bcba17279327c6e85dee6a97014dc642e2dc93cc
[2/4] ASoC: qcom: sdw: remove redundant code
commit: d02460317ed9c95aa2c5f6ff1c70e22e1857d95d
[3/4] ASoC: qcom: sdm845: make use of common helpers
commit: 5fa671232f703a404caa05c581411ea858c4cf16
[4/4] ASoC: qcom: sc7280: make use of common helpers
commit: 8fdb030fe283c84fd8d378c97ad0f32d6cdec6ce
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2025-10-30 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 14:33 [PATCH v3 0/4] ASoC: qcom: sdw: fix memory leak Srinivas Kandagatla
2025-10-22 14:33 ` [PATCH v3 1/4] ASoC: qcom: sdw: fix memory leak for sdw_stream_runtime Srinivas Kandagatla
2025-10-22 14:33 ` [PATCH v3 2/4] ASoC: qcom: sdw: remove redundant code Srinivas Kandagatla
2025-10-22 14:33 ` [PATCH v3 3/4] ASoC: qcom: sdm845: make use of common helpers Srinivas Kandagatla
2025-10-22 14:33 ` [PATCH v3 4/4] ASoC: qcom: sc7280: " Srinivas Kandagatla
2025-10-30 16:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176184301177.119935.14003591741907115293.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=alexey.klimov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox