Re: [PATCH v2 0/9] remoteproc: qcom_q6v5_wcss: add native ipq9574 support

[Rob Herring <robh@kernel.org>]

On Thu, 08 Jan 2026 22:33:35 -0600, Alexandru Gagniuc wrote:
> Support loading remoteproc firmware on IPQ9574 with the qcom_q6v5_wcss
> driver. This firmware is usually used to run ath11k firmware and enable
> wifi with chips such as QCN5024.
> 
> When submitting v1, I learned that the firmware can also be loaded by
> the trustzone firmware. Since TZ is not shipped with the kernel, it
> makes sense to have the option of a native init sequence, as not all
> devices come with the latest TZ firmware.
> 
> Qualcomm tries to assure us that the TZ firmware will always do the
> right thing (TM), but I am not fully convinced, and believe there is
> justification for a native remoteproc loader. Besides, this series
> has improvements to the existing code.
> 
> Changes since v1:
>  - Improve bindings following review feedback
>  - disable clocks on init failures in q6v7_wcss_reset()
>  - review-suggetsed readability improvements of qcom_q6v5_wcss
> 
> Alexandru Gagniuc (9):
>   remoteproc: qcom_q6v5_wcss: drop unused clocks from q6v5 struct
>   dt-bindings: remoteproc: qcom,ipq8074-wcss-pil: convert to DT schema
>   dt-bindings: clock: gcc-ipq9574: add wcss remoteproc clocks
>   dt-bindings: remoteproc: qcom: add IPQ9574 image loader
>   arm64: dts: qcom: ipq9574: add wcss remoteproc nodes
>   clk: qcom: gcc-ipq9574: add wcss remoteproc clocks
>   remoteproc: qcom_q6v5_wcss: support IPQ9574
>   remoteproc: qcom_q6v5_wcss: support m3 firmware
>   remoteproc: qcom_q6v5_wcss: use bulk clk API for q6 clocks in QCS404
> 
>  .../remoteproc/qcom,ipq8074-wcss-pil.yaml     | 268 ++++++++++++
>  .../bindings/remoteproc/qcom,q6v5.txt         | 102 -----
>  arch/arm64/boot/dts/qcom/ipq9574.dtsi         | 101 +++++
>  drivers/clk/qcom/gcc-ipq9574.c                | 378 +++++++++++++++++
>  drivers/remoteproc/qcom_q6v5_wcss.c           | 398 ++++++++++++++----
>  include/dt-bindings/clock/qcom,ipq9574-gcc.h  |  22 +
>  6 files changed, 1082 insertions(+), 187 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml
>  delete mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
> 
> --
> 2.45.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.19-rc2-7-ge190ecec2fdf (exact match)
 Base: tags/v6.19-rc2-7-ge190ecec2fdf (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260109043352.3072933-1-mr.nuke.me@gmail.com:

arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb: smp2p-wcss (qcom,smp2p): master-kernel: 'qcom,smp2p-feature-ssr-ack' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml
arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: smp2p-wcss (qcom,smp2p): master-kernel: 'qcom,smp2p-feature-ssr-ack' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml
arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb: smp2p-wcss (qcom,smp2p): master-kernel: 'qcom,smp2p-feature-ssr-ack' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml
arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: smp2p-wcss (qcom,smp2p): master-kernel: 'qcom,smp2p-feature-ssr-ack' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml
arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb: smp2p-wcss (qcom,smp2p): master-kernel: 'qcom,smp2p-feature-ssr-ack' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml