Re: [PATCH v9 0/5] Add CCI and imx577 sensor support for monaco evk

[Rob Herring <robh@kernel.org>]

On Thu, 22 Jan 2026 00:01:37 +0530, Nihal Kumar Gupta wrote:
> From: Nihal Kumar Gupta <nihalkum@qti.qualcomm.com>
> 
> Monaco EVK is a single-board computer based on the Qualcomm QCS8300 SoC.
> It lacks a camera sensor in its default configuration.
> This series adds CCI support and enables the IMX577 sensor via CSIPHY1
> through device tree overlay.
> 
> We have tested IMX577 Sensor on CCI1 with following commands:
> - media-ctl --reset
> - media-ctl -V '"imx577 3-001a":0[fmt:SRGGB10/4056x3040 field:none]'
> - media-ctl -V '"msm_csiphy1":0[fmt:SRGGB10/4056x3040]'
> - media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
> - media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
> - media-ctl -l '"msm_csiphy1":1->"msm_csid0":0[1]'
> - media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
> - yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video1
> ---
> 
> Changes in v9:
> - Added i2c maintainers and linux-i2c mailing list for the qcom,i2c-cci.yaml
>   dt-bindings patch - Bryan
> - Rebased onto the latest master.
> - Link to v8:
>   https://lore.kernel.org/all/20251222095914.1995041-1-quic_nihalkum@quicinc.com
> 
> Changes in v8:
> - Removed clock-lanes property from CAMSS node - Vladimir
> - Changed data-lanes property to <1 2 3 4> on sensor node - Vladimir
> - Sorted regulator entries with respect to the pin index - Konrad
> - Link to v7:
>   https://lore.kernel.org/all/20251216062223.2474216-1-quic_nihalkum@quicinc.com
> 
> Changes in v7:
> - Define MCLK pinctrl definitions in monaco.dtsi - Konrad and Vladimir
> - Define fixed regulators for camera AVDD rails in monaco-evk.dts - Konrad
> - Link to v6:
>   https://lore.kernel.org/all/20251126081057.4191122-1-quic_vikramsa@quicinc.com
> 
> Changes in v6:
> - Fixed ordering of property-n and property-names in vreg_cam1_2p8 - Konrad
> - Moved vreg_cam1_2p8 defintion to monaco-evk.dts - Konrad
> - Removed description of pins with MCLK and Regulators function - Konrad
> - Added pin hardware description for MCLK, regulators in monaco.dtsi - Konrad
> - Link to v5:
>   https://lore.kernel.org/all/20251114064541.446276-1-quic_vikramsa@quicinc.com
> 
> Changes in v5:
> - Rename cciX_i2cY_* to cciX_Y_* to shorten the labels - Vladimir
> - Added description of pins with MCLK function - Vladimir
> - Link to v4:
>   https://lore.kernel.org/all/20251015131303.2797800-1-quic_vikramsa@quicinc.com
> 
> Changes in v4:
> - Remove the AXI source clock from the CCI node - Konrad
> - Updated the qcs8300-camss device tree binding.
> - Link to v3:
>   https://lore.kernel.org/all/20250917130647.1701883-1-quic_vikramsa@quicinc.com
> 
> Changes in v3:
> - Updated and Wrapped commit messages for [PATCH v2 1/3] and [PATCH v2 2/3] - Rob
> - Link to v2:
>   https://lore.kernel.org/all/20250912141134.2799078-1-quic_vikramsa@quicinc.com
> 
> Changes in v2:
> - Remove the patch that adds PHY supply documentation in the qcs8300 CAMSS.
>   bindings. This change should be submitted together with the qcs8300 bindings patch.
> - Fix indentation and regulator node name - Krzysztof.
> - Update commit message as suggested - Dmitry.
> - Link to v1:
>   https://lore.kernel.org/lkml/20250909114241.840842-1-quic_vikramsa@quicinc.com
> 
> Used following tools for the sanity check of these changes.
> - make -j32 W=1
> - checkpatch.pl
> - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=i2c/qcom,i2c-cci.yaml dt_binding_check
> - make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=i2c/qcom,i2c-cci.yaml
> - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=media/qcom,qcs8300-camss.yaml dt_binding_check
> - make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,qcs8300-camss.yaml
> 
> Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@quicinc.com>
> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
> 
> Nihal Kumar Gupta (5):
>   dt-bindings: i2c: qcom-cci: Document qcs8300 compatible
>   arm64: dts: qcom: monaco: Add CCI definitions
>   arm64: dts: qcom: monaco: Add camera MCLK pinctrl
>   arm64: dts: qcom: monaco-evk: Add camera AVDD regulators
>   arm64: dts: qcom: monaco-evk-camera: Add DT overlay
> 
>  .../devicetree/bindings/i2c/qcom,i2c-cci.yaml |   2 +
>  arch/arm64/boot/dts/qcom/Makefile             |   4 +
>  .../dts/qcom/monaco-evk-camera-imx577.dtso    |  66 ++++
>  arch/arm64/boot/dts/qcom/monaco-evk.dts       |  51 +++
>  arch/arm64/boot/dts/qcom/monaco.dtsi          | 324 ++++++++++++++++++
>  5 files changed, 447 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20260121 (exact match)
 Base: tags/next-20260121 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260121183142.1867199-1-quic_nihalkum@quicinc.com:

arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: cci@ac14000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: cci@ac14000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk.dtb: cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtb: cci@ac13000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtb: cci@ac14000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml
arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtb: cci@ac15000 (qcom,qcs8300-cci): clock-names:0: 'ahb' was expected
	from schema $id: http://devicetree.org/schemas/i2c/qcom,i2c-cci.yaml