From: netdev-bot+sashiko@kernel.org
To: mohd.anwar@oss.qualcomm.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, afd@ti.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
richardcochran@gmail.com, andersson@kernel.org,
konradybcio@kernel.org, alexandre.torgue@foss.st.com,
peppe.cavallaro@st.com, joabreu@synopsys.com,
maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com,
lorenzo.bianconi@oss.qualcomm.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v4 03/10] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible
Date: Fri, 20 Nov 2026 11:45:56 +0000 [thread overview]
Message-ID: <179517515650.3136.1478544566840893554@kernel.org> (raw)
In-Reply-To: <20261117-shikra_ethernet-v4-3-c41902e5f2fa@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit message says the if/else block constrains Shikra
"while leaving existing compatibles unchanged", but the schema now…
- [Low] The Shikra `then:` block (lines 116-130 of qcom,ethqos.yaml)
requires exactly six clocks ending in `axi-noc`, `pcie-tile-axi-noc`…
- [Low] For Shikra, the `then:` branch of qcom,ethqos.yaml fixes clock
index 3 to `const: rgmii` (line 125).
--
dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible
This adds a qcom,shikra-ethqos compatible to the qcom,ethqos and
snps,dwmac bindings. Shikra's EMAC needs two extra NOC clocks (axi-noc,
pcie-tile-axi-noc) and an OPP table to vote VDD_CX. An if/else block
limits Shikra to six clocks and requires operating-points-v2 and
power-domains.
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index ef520f8105773..6bd4bded650a4 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
[ ... ]
> @@ -81,6 +83,14 @@ properties:
> - const: cpu-mac
> - const: mac-mem
>
> + operating-points-v2:
> + description: |
> + For Shikra, the OPP table specifies the rates for the NOC access
> + clocks in "stmmaceth", "axi-noc", "pcie-tile-axi-noc" order.
> +
> + opp-table:
> + type: object
> +
[Severity: Low]
The commit message says the if/else block constrains Shikra "while
leaving existing compatibles unchanged". Is that true for these two
properties?
operating-points-v2 and opp-table are added to the top-level properties
without any compatible gating. The else branch further down only narrows
clocks and clock-names.
At the baseline, neither snps,dwmac.yaml nor any other binding under
bindings/net/ defined these properties, and this file ends with
unevaluatedProperties: false. An OPP table on a qcs404, qcs615, sa8775p,
qcs8300, sc8280xp or sm8150 ethqos node used to fail dtbs_check. With
this patch it passes.
The property description says it applies to Shikra. Later in the series,
the driver reads the OPP table only when num_noc_clks is set, which is
only the case for shikra_data.
Could the else branch add operating-points-v2: false and opp-table:
false? Or should the commit message be adjusted?
[ ... ]
> @@ -95,6 +105,42 @@ required:
> - clock-names
> - reg-names
>
> +allOf:
> + - $ref: snps,dwmac.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,shikra-ethqos
> + then:
> + properties:
> + clocks:
> + minItems: 6
> + clock-names:
> + items:
> + - const: stmmaceth
> + - const: pclk
> + - const: ptp_ref
> + - const: rgmii
[Severity: Low]
Does fixing the fourth clock to rgmii mean SGMII/serdes boards can't be
described on Shikra?
The top-level schema still allows phys and phy-names = serdes for
Shikra, but phyaux is rejected here.
The Shikra GCC exposes PHY AUX and SGMIIPHY RX/TX clocks for both EMACs:
drivers/clk/qcom/gcc-shikra.c:gcc_shikra_clocks[] {
...
[GCC_EMAC0_PHY_AUX_CLK] = &gcc_emac0_phy_aux_clk.clkr,
...
}
The SGMII-capable ethqos SoCs (sa8775p and qcs8300, with link_clk_name =
"phyaux" in emac_v4_0_0_data) use these clocks for the serdes path.
On a Shikra board wired for SGMII through the serdes, a phyaux link
clock would fail dtbs_check. ethqos_hlos_setup() would also fetch
"rgmii", because shikra_data sets no link_clk_name:
ethqos->link_clk = devm_clk_get(dev, ethqos->data->link_clk_name ?: "rgmii");
If SGMII is intentionally unsupported on Shikra, could the commit
message say so? If not, should this be an enum of rgmii and phyaux, as
it is for the other compatibles? Bindings are expected to describe the
hardware even where the driver lacks support.
> + - const: axi-noc
> + - const: pcie-tile-axi-noc
[Severity: Low]
Does every Shikra EMAC instance really need pcie-tile-axi-noc?
This then block requires all six clocks on every qcom,shikra-ethqos node
and does not distinguish the two EMAC instances.
In gcc-shikra.c, gcc_pcie_tile_axi_sys_noc_clk has gcc_emac0_axi_clk_src
as its only parent, with CLK_SET_RATE_PARENT:
.name = "gcc_pcie_tile_axi_sys_noc_clk",
.parent_hws = (const struct clk_hw*[]) {
&gcc_emac0_axi_clk_src.clkr.hw,
},
.num_parents = 1,
.flags = CLK_SET_RATE_PARENT,
EMAC1's own clocks, gcc_emac1_axi_clk and gcc_emac1_axi_sys_noc_clk, come
from a separate RCG, gcc_emac1_axi_clk_src.
To pass the schema, an EMAC1 node therefore has to reference a clock in
EMAC0's tree. Later in the series, qcom_ethqos_set_opp() calls
dev_pm_opp_set_opp() for EMAC1, and dev_pm_opp_config_clks_simple()
calls clk_set_rate() on that clock. The rate would propagate to EMAC0's
AXI RCG, and EMAC1 would keep that RCG enabled.
If EMAC1 has no PCIe-tile NOC path in hardware, should it be allowed
five clocks? If it does have one, could the commit message mention it?
This series adds no Shikra ethernet node to shikra.dtsi, so the intended
EMAC1 wiring can't be checked.
> + required:
> + - operating-points-v2
> + - power-domains
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117-shikra_ethernet-v4-0-c41902e5f2fa%40oss.qualcomm.com
next prev parent reply other threads:[~2026-11-20 11:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:45 [PATCH net-next v4 00/10] net: stmmac: qcom-ethqos: add Shikra EMAC support Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 01/10] dt-bindings: net: ti,dp83867: add supply properties Mohd Ayaan Anwar
2026-11-18 18:58 ` Rob Herring (Arm)
2026-11-17 8:45 ` [PATCH net-next v4 02/10] net: phy: dp83867: add regulator supply management Mohd Ayaan Anwar
2026-11-20 11:45 ` netdev-bot+sashiko
2026-11-17 8:45 ` [PATCH net-next v4 03/10] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible Mohd Ayaan Anwar
2026-11-18 19:07 ` Rob Herring
2026-11-20 11:45 ` netdev-bot+sashiko [this message]
2026-11-17 8:45 ` [PATCH net-next v4 04/10] net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 05/10] net: stmmac: qcom-ethqos: add DLL-bypass for PHY-managed RGMII delays Mohd Ayaan Anwar
2026-11-20 11:45 ` netdev-bot+sashiko
2026-11-17 8:45 ` [PATCH net-next v4 06/10] net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed Mohd Ayaan Anwar
2026-11-18 9:13 ` Lorenzo Bianconi
2026-11-17 8:45 ` [PATCH net-next v4 07/10] net: stmmac: qcom-ethqos: share common GMAC4 address table Mohd Ayaan Anwar
2026-11-17 8:45 ` [PATCH net-next v4 08/10] net: stmmac: qcom-ethqos: add per-platform NOC clock voting Mohd Ayaan Anwar
2026-11-18 9:40 ` Lorenzo Bianconi
2026-11-17 8:45 ` [PATCH net-next v4 09/10] net: stmmac: qcom-ethqos: add Shikra EMAC support Mohd Ayaan Anwar
2026-11-18 9:43 ` Lorenzo Bianconi
2026-11-20 11:46 ` netdev-bot+sashiko
2026-11-17 8:45 ` [PATCH net-next v4 10/10] net: stmmac: qcom-ethqos: add QCS615 " Mohd Ayaan Anwar
2026-11-18 9:44 ` Lorenzo Bianconi
2026-11-20 11:46 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179517515650.3136.1478544566840893554@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=afd@ti.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox