From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F78FC433EF for ; Tue, 9 Nov 2021 16:22:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03D6860F4A for ; Tue, 9 Nov 2021 16:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237447AbhKIQZG (ORCPT ); Tue, 9 Nov 2021 11:25:06 -0500 Received: from foss.arm.com ([217.140.110.172]:35694 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234118AbhKIQZF (ORCPT ); Tue, 9 Nov 2021 11:25:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 049CAED1; Tue, 9 Nov 2021 08:22:19 -0800 (PST) Received: from [10.57.26.224] (unknown [10.57.26.224]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03C113F800; Tue, 9 Nov 2021 08:22:14 -0800 (PST) Subject: Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication To: Steev Klimaszewski Cc: Thara Gopinath , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk, gregkh@linuxfoundation.org, rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, bjorn.andersson@linaro.org, agross@kernel.org References: <20211103161020.26714-1-lukasz.luba@arm.com> <3cba148a-7077-7b6b-f131-dc65045aa348@arm.com> <9d533b6e-a81c-e823-fa6f-61fdea92fa65@kali.org> <74ea027b-b213-42b8-0f7d-275f3b84712e@linaro.org> <74603569-2ff1-999e-9618-79261fdb0ee4@kali.org> <59054c90-c1cd-85bf-406e-579df668d7b4@linaro.org> <2c54dbbd-2ecb-fb76-fa9f-9752f429c20e@linaro.org> <97e93876-d654-0a89-dce1-6fe1189345e2@kali.org> From: Lukasz Luba Message-ID: <19ecab72-4a2f-1f4a-b999-d3967a4a1a76@arm.com> Date: Tue, 9 Nov 2021 16:22:12 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11/9/21 3:46 PM, Steev Klimaszewski wrote: > > On 11/9/21 2:29 AM, Lukasz Luba wrote: >> Hi Steev, >> >> That's interesting what you've done with Rockchip RK3399. >> I would like to reproduce your experiment on my RockPI 4B v1.3. >> Could you tell me how you to add this boost frequency that you have >> mentioned in some previous emails? >> >> I want to have similar setup to yours and I'll check all the subsystems >> involved in the decision making process for triggering this boost freq. >> >> Thank you for your support. >> >> Regards, >> Lukasz > > > Hi Lukasz, > > It was actually something that Armbian had been doing as an overlay for > their setup, and I thought, why does it need to be an overlay, when we > could simply hide it behind turbo-mode so that if users want to > overclock, they simply echo 1 and if it's unstable or cooling/power > isn't enough, they can echo 0 or leave it off (boost defaults to off) - > so that being said: > > I apply this patch > https://gitlab.com/kalilinux/build-scripts/kali-arm/-/blob/master/patches/pinebook-pro/pbp-5.14/rk3399-opp-overclock-2GHz-turbo-mode.patch > which adds the 1.5GHz for little cores and 2GHz for the big to the > rk3399 dtsi > > To enable at boot time, I simply have "echo 1 > > /sys/devices/system/cpu/cpufreq/boost" in my /etc/rc.local  And to > disable, simply echo 0 in there (it defaults to 0 so it's off and most > users won't know it exists.) > > I'm pretty sure this is "abusing" turbo-mode, but it works well enough... > > Hope that helps, > Yes, that help. Thank you for the info. I'll play a bit with this boosting and try to figure out the mechanisms. For the $subject patch set, I'm going to send v4, since it's not affecting the boost usage. The newly introduced interface must handle these boost frequency values and not simply ignore them with also printing a warning. They are valid frequencies and we should just put 0 to the thermal pressure in such cases. Regards, Lukasz