From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dikshita Agarwal <quic_dikshita@quicinc.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>
Subject: Re: [PATCH 09/18] clk: qcom: gcc-sm8250: Set delay for Venus CLK resets
Date: Tue, 9 Jan 2024 10:33:39 +0100 [thread overview]
Message-ID: <19eceba8-dfc3-40d0-a681-8c47a0248cfd@linaro.org> (raw)
In-Reply-To: <0cbedc75-cacf-43f8-a1f9-284546ad548a@linaro.org>
On 1/9/24 01:34, Bryan O'Donoghue wrote:
> On 08/01/2024 12:32, Konrad Dybcio wrote:
>> Some Venus resets may require more time when toggling. Describe that.
>
> May or does ?
>
> I'd prefer a strong declaration of where this value came from and why its being added.
>
> May is ambiguous.
>
> "Downstream has a 150 us delay for this. My own testing shows this to be necessary in upstream"
Alright
>
> Later commits want to add a 1000 us delay. Have all of these delays been tested ?
No, we don't support Venus on many of the newer SoCs..
>
> If not please describe where the values come.
They come from the downstream Venus driver as you mentioned.
I checked a couple different downstream SoC kernel trees and
tried to assign the values based on what I found in a kernel
for that platform. Some are fairly educated guesses.
Konrad
next prev parent reply other threads:[~2024-01-09 9:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 12:32 [PATCH 00/18] Qualcomm GCC/VIDEOCC reset overhaul for Venus Konrad Dybcio
2024-01-08 12:32 ` [PATCH 01/18] clk: qcom: reset: Increase max reset delay Konrad Dybcio
2024-01-08 12:32 ` [PATCH 02/18] clk: qcom: reset: Commonize the de/assert functions Konrad Dybcio
2024-01-09 0:29 ` Bryan O'Donoghue
2024-01-08 12:32 ` [PATCH 03/18] clk: qcom: reset: Ensure write completion on reset de/assertion Konrad Dybcio
2024-01-08 12:32 ` [PATCH 04/18] clk: qcom: gcc-sa8775p: Set delay for Venus CLK resets Konrad Dybcio
2024-01-08 12:32 ` [PATCH 05/18] clk: qcom: gcc-sc8180x: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 06/18] clk: qcom: gcc-sc8280xp: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 07/18] clk: qcom: gcc-sm4450: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 08/18] clk: qcom: gcc-sm7150: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 09/18] clk: qcom: gcc-sm8250: " Konrad Dybcio
2024-01-09 0:34 ` Bryan O'Donoghue
2024-01-09 9:33 ` Konrad Dybcio [this message]
2024-01-27 23:05 ` Bjorn Andersson
2024-01-08 12:32 ` [PATCH 10/18] clk: qcom: gcc-sm8350: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 11/18] clk: qcom: gcc-sm8450: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 12/18] clk: qcom: gcc-sm8550: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 13/18] clk: qcom: gcc-sm8650: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 14/18] clk: qcom: videocc-sm8150: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 15/18] clk: qcom: videocc-sm8250: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 16/18] clk: qcom: videocc-sm8350: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 17/18] clk: qcom: videocc-sm8450: " Konrad Dybcio
2024-01-08 12:32 ` [PATCH 18/18] clk: qcom: videocc-sm8550: " Konrad Dybcio
2024-01-08 23:45 ` [PATCH 00/18] Qualcomm GCC/VIDEOCC reset overhaul for Venus Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19eceba8-dfc3-40d0-a681-8c47a0248cfd@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_dikshita@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox