From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEADA2586EB for ; Tue, 29 Apr 2025 19:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745953402; cv=none; b=e+j4EGJv8HctgG9EdUS/qFtuH4LpxPzkCvCAJNdcwyH1yJbi8eUj6Pxcy/2v4YoTD41nBBmPYhA9S0+JOCR6H8lW8BOn2qvtZZngSD2v3f67/OabYv9gZSDxWEiQRc6/xF9sXCJugGQwFbGORx7W3skMuRuyCxR6IBOV69/pOw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745953402; c=relaxed/simple; bh=enZuKg0Yho7LCctoR7MuGNSzlG3syPAETBOCsWhHujw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sTvL7KNuNlZOOAMbdDZjs4Bqii4LJiI3/otlPUZ5P7weL707mdUXFDw1Sksv5r+FKtHYaNiWFfSVNEQIy/33XFZBqIqZZXyEC3sZZUJmB5DFxL7KLjmaCPySp5ikWdrY7sDKAHZO45U/1/3x2VMo+JcuRB1C9zu9h0BiVEnozhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gjMpvrBN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gjMpvrBN" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53T9gEcm021614 for ; Tue, 29 Apr 2025 19:03:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SFUA+vmGXvWQaDUz0FTdKxJwrF/zWygzDZetk0yUquU=; b=gjMpvrBNaQpK7ZTM /lZ+msm1SX3oCVf8quRBsXx5dh/hKVK9J5Szu9lfFVWpujNcNmX02GAfoAfnclFc 3tB8hFlbTlZ45zUcsrelRS0Puwvn0Cues542/mqCrtnE7kfBvMd0T55F5sjEqqbS ghNtliBZCDlrG+Ar8JTr8tlQkw/v4Fi8TI0bzMMfDm5tp3POiQG+STBNb9q+AAF/ PTnsgIku9XFPdoV60bI3EbjWr3z+YxQxOD0pWZsU3LN/VJxg2Uma5kdsHdRyuIjY iXapfUQDEQraQemqlAAbW+Yd7kzlw5kSr0N/hnplH7xI3zj56hfaJfMVo2r4vJHj xgCNgA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 468qq5mr20-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 29 Apr 2025 19:03:18 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-47ae9ed8511so11962401cf.3 for ; Tue, 29 Apr 2025 12:03:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745953397; x=1746558197; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SFUA+vmGXvWQaDUz0FTdKxJwrF/zWygzDZetk0yUquU=; b=l6/yZ9oVOj7/7SKUxQ1+nOKkCrPDccCOSc03WoQ0myjdskHI2o3QprabVp3Y2HTht7 xaZoTbhZTcnGdcMfW9xD3c+M9OSEeLhirHa47GiEgzJrIs3wR03WYUQ6anLi8X/VxGds 5+aou/UGSgcmBmbsY8BMxGlGCJtjbyOngL5/wW6jbvPPABtu06y9DiDrqJApEQrxN4F6 +iRciv3V3gmHGhJo/x7zqLIAZx7v9tU6NBmNcW+JP3TAWeAjs5IP4u1sN1IgJxa//yfP U6E92r0uC6eA/XfHb/k+JnwoATS2reDNSz5HWbDVO7pcX/UGql3Q1+TlWUQJ0gMFHGKo xcVg== X-Forwarded-Encrypted: i=1; AJvYcCUl/VTgnYdrSolGqINScxMxhtcI5HsfpuiMMd3q2aLVmKMHztNkNYCABkHcgEn6+BoBycJYQHfqt+n0j6+t@vger.kernel.org X-Gm-Message-State: AOJu0Yx0+Ytuwwc9qFK/C49nf04tNxd9XVI7XsVSB61lSFPIuiaV8ljt WufNR8l13wCey+m+vxhbFQ/ueAjdgmLYm3P+lMkt5wSil/PnuLAbnpXH0UUaiLDbKr1KJsE/7kx IRVgP0IE2eDRQrTrrzwEJuihLBM+v0JeuFPYelZljqDZi1aj1QHV55mfI2CpJfaeR X-Gm-Gg: ASbGncu7572nX62r3bYwq/OXprAphza6eiDQp3SN0GqEzyl2dnv8IBCkWMeHPi3ePBO nIIJEZ32af15/BmTt2a7uzRCqEZP0nKniTq9UVKRoIOhUjlhydEFLhA+qpxe0ap//iP6ecTDevW C1eS2TKydJBCv5uqBm31yh/2H5LUANLx9d1kQ4SUYi4wH6Hi21TCzROz7oJ9JmyombSLGUJttny f1tNg13uG8Uq0Iq/y+SmE06BkW/8J5uih0Ou41nUWKzUxBzIO1puIpv+E1uOYAmFw87aaasmD9C VPc+LSulaJivmDagovC6qHqyhr9/oiB9/scJVNfhHXNREOaYdIL/7nxvD7yq2PGumQ== X-Received: by 2002:ac8:7fc1:0:b0:476:66fb:4df4 with SMTP id d75a77b69052e-489c0ecd9b5mr1232931cf.0.1745953397402; Tue, 29 Apr 2025 12:03:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4oXGFJFE688jinn7yYFdRyAJwph4UBQHGatqnUkCpVJYykMoY8ucb0lhtaDPLXOThnrZHrQ== X-Received: by 2002:ac8:7fc1:0:b0:476:66fb:4df4 with SMTP id d75a77b69052e-489c0ecd9b5mr1232631cf.0.1745953396777; Tue, 29 Apr 2025 12:03:16 -0700 (PDT) Received: from [192.168.65.43] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6ed6aebasm813646966b.128.2025.04.29.12.03.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 12:03:16 -0700 (PDT) Message-ID: <1a49959a-9f76-40ee-b221-c049ebc2bb09@oss.qualcomm.com> Date: Tue, 29 Apr 2025 21:03:13 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: clock: Add Qualcomm SC8180X Camera clock controller To: Vladimir Zapolskiy , Satya Priya Kakitapalli , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250422-sc8180x-camcc-support-v1-0-691614d13f06@quicinc.com> <20250422-sc8180x-camcc-support-v1-1-691614d13f06@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: L8PVoYeFvod9g1bkoMYb9U7dsIZGt10M X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI5MDE0MCBTYWx0ZWRfX071sH95XYrMu OO2ZED+iM2yTGcOrOPMy26ULT+/hso9F1djcQ0iRzZVTsjubfKfqA8xTBei4FPinR1vtO/GLdKv RnbQ4+3LQvIkPb2xCCZK47fuYE+clmqrj6uFQm5P4iH5xkxA+zktt+imssKWZMEMtLd1pHvGS7E 6v8PZqTUkBfq83yAL3UQnq7tMF4ozmjs2W0XJg4PvZsjNNmRAhKys1UMd8ZncYszRD7OHflktEl evB1buptTVsvi60Zz6KFSXukfdI8XJyTfpTw2stEcDQTn5GsL3sbeQDmNnURDwVnC9eDjjIoqmg kef71qTjXZHP47oOGcCVvhnv5NcKNHNwonFylgJqboIPtTiIAGoPfUIkfcK1VDyQFGBILYdxxy6 ZjO2agUOq4gRAcNgPtBSJ+dilAGpgB++82Rdfm2YcE+xVQCVJgvlzQe6wDI18EGnljcoSN8h X-Authority-Analysis: v=2.4 cv=QP1oRhLL c=1 sm=1 tr=0 ts=68112276 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=gEfo2CItAAAA:8 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=CIINWzuxR8hvsKXtIHkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: L8PVoYeFvod9g1bkoMYb9U7dsIZGt10M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-29_07,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 adultscore=0 mlxscore=0 bulkscore=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504290140 On 4/26/25 4:03 PM, Vladimir Zapolskiy wrote: > On 4/22/25 08:42, Satya Priya Kakitapalli wrote: >> Add device tree bindings for the camera clock controller on >> Qualcomm SC8180X platform. >> >> Signed-off-by: Satya Priya Kakitapalli >> --- >>   .../bindings/clock/qcom,sc8180x-camcc.yaml         |  65 ++++++++ >>   include/dt-bindings/clock/qcom,sc8180x-camcc.h     | 181 +++++++++++++++++++++ >>   2 files changed, 246 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml >> new file mode 100644 >> index 0000000000000000000000000000000000000000..b17f40ee53a3002b2942869d60773dbecd764134 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,sc8180x-camcc.yaml >> @@ -0,0 +1,65 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/qcom,sc8180x-camcc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Camera Clock & Reset Controller on SC8180X >> + >> +maintainers: >> +  - Satya Priya Kakitapalli >> + >> +description: | >> +  Qualcomm camera clock control module provides the clocks, resets and >> +  power domains on SC8180X. >> + >> +  See also: include/dt-bindings/clock/qcom,sc8180x-camcc.h >> + >> +properties: >> +  compatible: >> +    const: qcom,sc8180x-camcc >> + >> +  clocks: >> +    items: >> +      - description: Board XO source > > From sc8180x_rpmh_clocks[] in clk/qcom/clk-rpmh.c I get that there is > RPMH_CXO_CLK_A clock also, shall it be added to this list then? _AO only makes sense for CPU-XYZ clocks which (almost?) exclusively reside in gcc, and most of the time they aren't even necessary to describe in Linux I'm not sure there's anything in CAM_CC that would benefit from it XO_A is in the end the same physical clock as XO (or at least used to be) except it places a vote in RPMh such that the harwdare takes care of gating it upon cpuss suspend entry > > If yes, and taking into account Konrad's ask for GCC_CAMERA_AHB_CLK, it > implies that the new dt bindings can be omitted, instead please consider > to add the 'qcom,sc8180x-camcc' compatible into qcom,sa8775p-camcc.yaml. > > However still there is a difference, qcom,sa8775p-camcc and qcom,qcs8300-camcc > does not contain 'required-opps' property, it might be an omission over > there though, please double check it. The ultimate goal would be to get > a shorter list of different camcc dt bindings. for required-opps see: https://lore.kernel.org/linux-arm-msm/44dad3b5-ea3d-47db-8aca-8f67294fced9@quicinc.com/ Konrad