Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Griffin Kroah-Hartman" <griffin.kroah@fairphone.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, "Daniel Scally" <djrscally@gmail.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Wolfram Sang" <wsa@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable CCI pull-up
Date: Thu, 2 Oct 2025 14:45:49 +0200	[thread overview]
Message-ID: <1be80052-3ba5-46de-804a-de995f8db5d4@oss.qualcomm.com> (raw)
In-Reply-To: <20251002-dw9800-driver-v1-3-c305328e44f0@fairphone.com>

On 10/2/25 12:15 PM, Griffin Kroah-Hartman wrote:
> Enable vreg_l6p which is used as a pull-up for the CCI busses, to make
> sure I2C communication works as expected.
> 
> Signed-off-by: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>
> ---

Makes me wonder if we should maybe extend the CCI definition
(or maybe the common i2c-bus binding?) to accept an external
pull-up supply, as this is a common problem.. (+Bryan, Wolfram)

We could then shut down the regulator when cameras are not
in use, preserving some trace amounts of power.

Or maybe L6P is already used as a pull-up supply for more things
onboard and should be always-on either way? Could you please
check that, Griffin?

Konrad

>  arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> index e115b6a52b299ef663ccfb614785f8f89091f39d..2dd2c452592aa6b0ac826f19eb9cb1a8b90cee47 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> @@ -749,6 +749,8 @@ vreg_l6p: ldo6 {
>  				regulator-name = "vreg_l6p";
>  				regulator-min-microvolt = <1700000>;
>  				regulator-max-microvolt = <1904000>;
> +				/* Pull-up for CCI I2C busses */
> +				regulator-always-on;
>  			};
>  
>  			vreg_l7p: ldo7 {
> 

  reply	other threads:[~2025-10-02 12:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 10:15 [PATCH 0/4] Add support for Dongwoon Anatech DW9800K driver Griffin Kroah-Hartman
2025-10-02 10:15 ` [PATCH 1/4] dt-bindings: media: i2c: dw9719: Document DW9800K Griffin Kroah-Hartman
2025-10-08 20:02   ` Rob Herring (Arm)
2025-10-02 10:15 ` [PATCH 2/4] media: i2c: dw9719: Add DW9800K support Griffin Kroah-Hartman
2025-10-02 12:58   ` Luca Weiss
2025-10-03  7:04   ` Sakari Ailus
2025-10-02 10:15 ` [PATCH 3/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable CCI pull-up Griffin Kroah-Hartman
2025-10-02 12:45   ` Konrad Dybcio [this message]
2025-10-02 13:12     ` Bryan O'Donoghue
2025-10-02 13:14     ` Luca Weiss
2025-10-02 14:05       ` Wolfram Sang
2025-10-03 10:35     ` Kieran Bingham
2025-10-03 11:03       ` Konrad Dybcio
2025-10-02 10:15 ` [PATCH 4/4] arm64: dts: qcom: qcm6490-fairphone-fp5: Add UW cam actuator Griffin Kroah-Hartman
2025-10-02 13:16   ` Luca Weiss
2025-10-06  9:20   ` Konrad Dybcio
2025-10-06  9:44     ` Luca Weiss
2025-10-06 11:26       ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1be80052-3ba5-46de-804a-de995f8db5d4@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djrscally@gmail.com \
    --cc=git@apitzsch.eu \
    --cc=griffin.kroah@fairphone.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox