From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70CF525A2A2 for ; Mon, 5 May 2025 13:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746451371; cv=none; b=qDu8hlvF9ATwfPbtPeUpL5vz+k+rk6yVTa/eNUMOEFi2/V8MtxBoAWIG/p23OcFMGza7Pwn95U5R43eaJcT4/ZmT4haziY7I+ckFd2a72YlIN73WsyO3KXh8D2Sp2yzUZZvbehS9FCeFFKmA+fC5RBQzwATJ2jxn3uOEES79bjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746451371; c=relaxed/simple; bh=6b6UvFMmR5hwpyVwUTZJ+FnF2O3Be9wTrs/DC2KR41g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LoSqC1YiMU0ejYA1Q58WADARXYSoz0mbBKlIeKXXF+IPgXKR8rSzRdaBGKuiFS+y6LnYglS58cbbHwSsYXHt/dYuFRQaby+VEzqM14ZnKoM6nJeDVxXYzC2/kF0Kd5AxopLFVdUjwqdzoTn3y8+EF+1qf75/+75HXxGjr/RQMZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z4LYVcqN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z4LYVcqN" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 545Bv5DV003852 for ; Mon, 5 May 2025 13:22:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ipfJB44vaRrzzYNTr2RsUlxdMWhli5auraPTR3Cgev4=; b=Z4LYVcqNuIgKiZuC gpqHd1nOQkIWqdsTCdDD/SRC6CD9vxFK8GqqyRxpK/1cAngXBYt9yP4y7PIgXc19 hF1Ldglx+Z/jdO2/LB2crwfHJw4x5e529cpCTdBfOZekjg71Pw6NT1WrK7OmKtaH 6DklgYiPkci+Uh9MExRHI0K4DQ85vUWKuLdyhkFSmnZ+KFeKo1nmNcM28pbXUvo2 WUH45GXdRZeGPGD2hYYmXLVEpCRbRB+NpVs3lHvWHMcV5w++CTAEgeymmcJ9x7ZN vvPNUzvrw7svlrwBCOCsXG5lc1MXBVpXsRYtpFKWgJWN13j9t2z+lyp6g6C6MIKP 2YDaZw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46da55v6rg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 05 May 2025 13:22:48 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-476695e930bso12747501cf.2 for ; Mon, 05 May 2025 06:22:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746451367; x=1747056167; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ipfJB44vaRrzzYNTr2RsUlxdMWhli5auraPTR3Cgev4=; b=gxQ4aiQjzakDpeACPknx+4mIcB681zNFF6VpmgBTLOeR2t7AFDVq36bYp7znu6AgML 8oasGE2se7frIVgI0sYSuiH60uvkfc+lk6wbpIVcsHMaE/U5xA75N7MWld4hPwYP5JTq 1G0WAoJnXGm/TsJQur5rs6oYx/Rx3qVuu7xPvZEb4cTMLrCzupTf+JivgZGkxwNoX9D1 gsWMzvPAgucwDKDapyWCoJ7W4Z65bFlLMX9NANrl/T2MOehm0jpQaQ4+3nzuhYE9neOo mhnlUMhNcsSo00qOvtd7nhr73vUuBEvRLxmaLE/3b/Vwq8hTjuvG75KPBq1SKUk75C9z wunA== X-Forwarded-Encrypted: i=1; AJvYcCUTJKfNdr7cqZfXJLdUl3OksMVnuLeAALnw0it2dODjuZaCJ+a6kCbqCEE9MDTwzWaKM9TNImd4ge1GEJQK@vger.kernel.org X-Gm-Message-State: AOJu0YwnJ6817yHsu66RikksQ0hAOUysgQJYvjCEd9eqsOW9pjZzUMqP uIn6qIS6hQKZRwUAPqi5KuNRkqiU/Fp193TTH6wHNfKcYgNBajjtpAqM5hp8nxXPE2WoL3U/lH8 85aRSFmxye/eyWMddNQzHdmWrljXwV1LWWrnZxJP2txWL0J1JjYV0coGvp78qTgkh X-Gm-Gg: ASbGncsJFarHzjpZeJpnR9as+4PL2eceb4rSE+dzWjCkzDxqgybwHb/53SG53RpRoOV gvllLncuWdS/dUoz+Y2irgS1G7cLSat9KHGsF7MliRMEbeAEuC7kXZvN7CzAYEv7rjrTFsF1N2a woGBhB6O9y5tDGkFll7pu3IqIro8uG1J08n9+TuilQiCMeG7MWklUDNpRh1nc4HuDBfb1HUAffA 5URzfMLX8EySe4vlRNT8fTMhN2KgXfHydA/tl/1Ma7gbxkGyXZGJhNfHJ0TsAjF48/n9pS0PVBs HRLMEYYFyWKjTCv4Os6niD9lMJMmOfFNb31NJrYXVIOb+I3skudRm9LVT51m7nU5IGY= X-Received: by 2002:ac8:5996:0:b0:48a:80e5:72bb with SMTP id d75a77b69052e-48c30d83ddcmr76442091cf.2.1746451367441; Mon, 05 May 2025 06:22:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjFC3fECabwesq4x5Fiy2V1yv92KY/9fO0f8AU4OsYx1OHQ7BrNcRSdkmpG2hw9MT3iHS01A== X-Received: by 2002:ac8:5996:0:b0:48a:80e5:72bb with SMTP id d75a77b69052e-48c30d83ddcmr76441901cf.2.1746451367042; Mon, 05 May 2025 06:22:47 -0700 (PDT) Received: from [192.168.65.169] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad18950ac90sm494506966b.150.2025.05.05.06.22.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 06:22:46 -0700 (PDT) Message-ID: <1cd1d97f-a6f1-43e6-8451-b9433db93c16@oss.qualcomm.com> Date: Mon, 5 May 2025 15:22:44 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] dt-bindings: clock: qcom: Add missing bindings on gcc-sc8180x To: Krzysztof Kozlowski , Satya Priya Kakitapalli Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Ajit Pandey , Imran Shaik , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250430-sc8180x-camcc-support-v2-0-6bbb514f467c@quicinc.com> <20250430-sc8180x-camcc-support-v2-1-6bbb514f467c@quicinc.com> <20250502-singing-hypersonic-snail-bef73a@kuoka> <35662ebc-d975-4891-8cbb-1ba3c324f504@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <35662ebc-d975-4891-8cbb-1ba3c324f504@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTA1MDEyOSBTYWx0ZWRfX3zppME8IgXrI 81W5SoTAvhfsvrla2PHOCVprp+58ohN97+PkM11NngLzCl0D1An6Kd2vBOQ1hHp4LecnOdS11J8 0sJcyEeNIGLzqNnl6NBgMyszVjGMTsZUHks/ylXyITy1shSe2ULzYXwexZLLA3ykZGgM0x+Q1/S Yj+nAh5YW2t3WuGKwrI80RoeGTam0u91M8cJ6OiFRLPgJ5H/Jbgenu3Kn78TJF5vh5oz7kvO9CY iftfAxvB7zMdb41A1aZquicdncHrW6AbPezOyHxP11fPJrap1ezmg0Y0xQOIV0fcgWcAyv1UwJ4 S0BFnCKZ+yoalX0xIWdtqa7mdnM6UyyrpHzp/0aBcf3b3QEIvIALbyRs5tT9GpsJIcxmxXn4Voi mM5pmrtrZ2IlDkxj4HLmgmtvCl7/60s8bzxa/mrgINEjxfBhIKNsZr1DuZFVaJHRN9FZoqOk X-Authority-Analysis: v=2.4 cv=M9RNKzws c=1 sm=1 tr=0 ts=6818bba8 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=bJQp2htD3s1xF4Ub2coA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: ZRB8QADkuN5xc3e92CUMRu1dBXty2sBQ X-Proofpoint-ORIG-GUID: ZRB8QADkuN5xc3e92CUMRu1dBXty2sBQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-05_06,2025-05-05_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 mlxlogscore=868 priorityscore=1501 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505050129 On 5/5/25 11:46 AM, Krzysztof Kozlowski wrote: > On 05/05/2025 11:43, Satya Priya Kakitapalli wrote: >> >> On 5/2/2025 12:15 PM, Krzysztof Kozlowski wrote: >>> On Wed, Apr 30, 2025 at 04:08:55PM GMT, Satya Priya Kakitapalli wrote: >>>> Add all the missing clock bindings for gcc-sc8180x. >>>> >>>> Fixes: 0fadcdfdcf57 ("dt-bindings: clock: Add SC8180x GCC binding") >>>> Cc: stable@vger.kernel.org >>> What sort of bug is being fixed here? This needs to be clearly expressed >>> in commit msg - bug or observable issue. >> >> >> The multi-media AHB clocks are needed to create HW dependency in the >> multimedia CC dt blocks and avoid any issues. They were not defined in >> the initial bindings. >> >> Sure, I'll add the details in the commit text. > > I don't understand what is the bug here. You just described missing feature. i.e. this patch is fine, but the fixes tag doesn't apply, as it doesn't really fix anything on its own Konrad