From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>, andersson@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] firmware: qcom: scm: Rework dload mode availability check
Date: Fri, 22 Mar 2024 19:24:07 +0100 [thread overview]
Message-ID: <1d62c159-a484-4eb4-a238-c4b6fb22fad0@linaro.org> (raw)
In-Reply-To: <1711034642-22860-3-git-send-email-quic_mojha@quicinc.com>
On 21.03.2024 16:24, Mukesh Ojha wrote:
> QCOM_SCM_BOOT_SET_DLOAD_MODE scm command is applicable for very
> older SoCs where this command is supported from firmware and
> for newer SoCs, dload mode tcsr registers is used for setting
> the download mode.
This is a bit of a spaghetti sentence, but I get what you're saying.
And the patch looks good!
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2024-03-22 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 15:23 [PATCH v2 1/4] firmware: qcom: scm: Remove log reporting memory allocation failure Mukesh Ojha
2024-03-21 15:24 ` [PATCH v2 2/4] firmware: scm: Remove redundant scm argument from qcom_scm_waitq_wakeup() Mukesh Ojha
2024-03-22 18:22 ` Konrad Dybcio
2024-03-21 15:24 ` [PATCH v2 3/4] firmware: qcom: scm: Rework dload mode availability check Mukesh Ojha
2024-03-22 18:24 ` Konrad Dybcio [this message]
2024-03-21 15:24 ` [PATCH v2 4/4] firmware: qcom: scm: Fix __scm and waitq completion variable initialization Mukesh Ojha
2024-04-05 15:40 ` [PATCH v2 1/4] firmware: qcom: scm: Remove log reporting memory allocation failure Mukesh Ojha
2024-04-21 22:29 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d62c159-a484-4eb4-a238-c4b6fb22fad0@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox