From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Richard Acayan <mailingradian@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH v9 3/5] media: qcom: camss: add support for SDM670 camss
Date: Tue, 24 Dec 2024 01:01:11 +0000 [thread overview]
Message-ID: <1de7bfd7-0bd0-4e14-b52a-ed6e3bb7a09c@linaro.org> (raw)
In-Reply-To: <20241218231729.270137-10-mailingradian@gmail.com>
On 18/12/2024 23:17, Richard Acayan wrote:
> + .clock = { "soc_ahb", "cpas_ahb",
> + "csiphy0", "csiphy0_timer" },
Broken indentation here and in several other places - please fix.
Also you should rebase on media-staging as a 3way merge is required ATM.
media-stage git://linuxtv.org/media_stage.git (fetch)
Other than that, this looks good.
Once you've addressed the above add.
git am /tmp/\[PATCH\ v9\ 3_5\]\ media:\ qcom:\ camss:\ add\ support\
for\ SDM670\ camss\ -\ Richard\ Acayan\ \<mailingradian@gmail.com\>\ -\
2024-12-18\ 2317.eml -3
Applying: media: qcom: camss: add support for SDM670 camss
Using index info to reconstruct a base tree...
M drivers/media/platform/qcom/camss/camss.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/media/platform/qcom/camss/camss.c
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2024-12-24 1:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 23:17 [PATCH v9 0/5] Add SDM670 camera subsystem Richard Acayan
2024-12-18 23:17 ` [PATCH v9 1/5] dt-bindings: clock: qcom,sdm845-camcc: add sdm670 compatible Richard Acayan
2024-12-18 23:17 ` [PATCH v9 2/5] dt-bindings: media: camss: Add qcom,sdm670-camss Richard Acayan
2024-12-18 23:17 ` [PATCH v9 3/5] media: qcom: camss: add support for SDM670 camss Richard Acayan
2024-12-24 1:01 ` Bryan O'Donoghue [this message]
2024-12-18 23:17 ` [PATCH v9 4/5] arm64: dts: qcom: sdm670: add camcc Richard Acayan
2024-12-23 12:09 ` Konrad Dybcio
2024-12-18 23:17 ` [PATCH v9 5/5] arm64: dts: qcom: sdm670: add camss and cci Richard Acayan
2025-01-07 16:38 ` (subset) [PATCH v9 0/5] Add SDM670 camera subsystem Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de7bfd7-0bd0-4e14-b52a-ed6e3bb7a09c@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox