From: Neil Armstrong <neil.armstrong@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8450: add crypto nodes
Date: Wed, 22 Mar 2023 11:18:42 +0100 [thread overview]
Message-ID: <1e03050c-38d1-f9a5-aaaf-0966b143147f@linaro.org> (raw)
In-Reply-To: <CAH=2NtwoLbjNV88DHbS27CwYA_Y-uoKAamKorhaUnany9akNWw@mail.gmail.com>
On 22/03/2023 11:15, Bhupesh Sharma wrote:
> On Wed, 22 Mar 2023 at 15:34, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>>
>> Add crypto engine (CE) and CE BAM related nodes and definitions
>> for the SM8450 SoC.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 7c1d1464a1f8..d7e0a1993558 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -4084,6 +4084,34 @@ ufs_mem_phy_lanes: phy@1d87400 {
>> };
>> };
>>
>> + cryptobam: dma-controller@1dc4000 {
>> + compatible = "qcom,bam-v1.7.0";
>
> This should be "qcom,bam-v1.7.4" instead, as per the HW documentation.
> Please refer to my patch here:
> https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/
>
> So, if you want I can modify this and fold it in my overall dts
> patchset, for which I am about to send a v2:
> https://lore.kernel.org/linux-arm-msm/20230321190118.3327360-1-bhupesh.sharma@linaro.org/
Sure take it in your v2 !
Neil
>
> Thanks,
> Bhupesh
>
>> + reg = <0 0x01dc4000 0 0x28000>;
>> + interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>;
>> + #dma-cells = <1>;
>> + qcom,ee = <0>;
>> + qcom,controlled-remotely;
>> + iommus = <&apps_smmu 0x584 0x11>,
>> + <&apps_smmu 0x588 0x0>,
>> + <&apps_smmu 0x598 0x5>,
>> + <&apps_smmu 0x59a 0x0>,
>> + <&apps_smmu 0x59f 0x0>;
>> + };
>> +
>> + crypto: crypto@1de0000 {
>> + compatible = "qcom,sm8450-qce", "qcom,sm8150-qce", "qcom,qce";
>> + reg = <0 0x01dfa000 0 0x6000>;
>> + dmas = <&cryptobam 4>, <&cryptobam 5>;
>> + dma-names = "rx", "tx";
>> + iommus = <&apps_smmu 0x584 0x11>,
>> + <&apps_smmu 0x588 0x0>,
>> + <&apps_smmu 0x598 0x5>,
>> + <&apps_smmu 0x59a 0x0>,
>> + <&apps_smmu 0x59f 0x0>;
>> + interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
>> + interconnect-names = "memory";
>> + };
>> +
>> sdhc_2: mmc@8804000 {
>> compatible = "qcom,sm8450-sdhci", "qcom,sdhci-msm-v5";
>> reg = <0 0x08804000 0 0x1000>;
>>
>> ---
>> base-commit: b12b871ec9079b0baefa69f8a869712682d16020
>> change-id: 20230322-topic-sm8450-upstream-qce-04daf8d81bb1
>>
>> Best regards,
>> --
>> Neil Armstrong <neil.armstrong@linaro.org>
>>
prev parent reply other threads:[~2023-03-22 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 10:04 [PATCH] arm64: dts: qcom: sm8450: add crypto nodes Neil Armstrong
2023-03-22 10:15 ` Bhupesh Sharma
2023-03-22 10:18 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e03050c-38d1-f9a5-aaaf-0966b143147f@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).