Re: [PATCH v4 6/6] arm64: dts: qcom: sm8350-lemonade(p): New devices

[Nia Espera <nespera@igalia.com>]

On 11/22/23 21:17, Konrad Dybcio wrote:
> 
> 
> On 11/11/23 23:07, Nia Espera wrote:
>> Device tree files for OnePlus 9 and 9 Pro. Details of supported features
>> mentioned in the cover letter for this patch series, but for
>> accessibility also repeated here:
>>
>> - USB OTG
>> - UFS
>> - Framebuffer display
>> - Touchscreen (for lemonade)
>> - Power & volume down keys
>> - Battery reading
>> - Modem, IPA, and remoteproc bringup
>>
>> Steps to get booting:
>>
>> - Wipe dtbo partition
>> - Flash vbmeta with disabled verity bit
>> - Flash kernel and initfs to boot partition with CLI args 
>> pd_ignore_unused
>> and clk_ignore_unused as v1 bootimg
>> - Flash rootfs to some other partition (probably super or userdata)
> Thanks for including this info here
> 
>> +&pmk8350_vadc {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&gpio1_adc_default>, <&gpio3_adc_default>;
>> +
>> +    /* pmk8350-ref-gnd */
> I fail to see the benefit in having this both here and in the label

Oops, removed.

>> +    channel@0 {
>> +        reg = <0x00>;
>> +        qcom,pre-scaling = <1 1>;
>> +        label = "pmk8350_ref_gnd";
>> +    };
>> +
> [...]
> 
>> +&tlmm {
>> +    gpio-reserved-ranges = <52 8>;
> Would you know what these are connected to?
> 

Judging from the line names on the hdk dtsi, 4 seem to be connected to 
the fingerprint (FP_SPI_*) and the other 4 are NFC-related 
(NFC_ESE_SPI_*). I can clarify this with a comment if necessary.

> [...]
> 
>> +&mpss {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&rf_cable_ant0_active>;
> patch-wide:
> 
> property-n
> property-names
> 
> Konrad

Many thanks!