From: "Arnd Bergmann" <arnd@arndb.de>
To: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Andersson" <andersson@kernel.org>
Cc: "Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/16] arm64: dts: qcom: sdm845: Fix the PCI I/O port range
Date: Tue, 28 Feb 2023 17:55:33 +0100 [thread overview]
Message-ID: <1e69e526-c270-49a0-bf00-8418d1aed121@app.fastmail.com> (raw)
In-Reply-To: <20230228164752.55682-2-manivannan.sadhasivam@linaro.org>
On Tue, Feb 28, 2023, at 17:47, Manivannan Sadhasivam wrote:
> For 1MiB of the I/O region, the I/O ports of the legacy PCI devices are
> located in the range of 0x0 to 0x100000. Hence, fix the bogus PCI addresses
> (0x60200000, 0x40200000) specified in the ranges property for I/O region.
> - ranges = <0x01000000 0x0 0x60200000 0 0x60200000 0x0 0x100000>,
> - <0x02000000 0x0 0x60300000 0 0x60300000 0x0 0xd00000>;
> + ranges = <0x01000000 0x0 0x00000000 0x0 0x60200000 0x0 0x100000>,
> + <0x02000000 0x0 0x60300000 0x0 0x60300000 0x0 0xd00000>;
>
This fixes the offset, but I wonder if the size of the I/O
window should be changed as well. The normal size is 64KB
(0x10000) per bus or less, while this one has 1MB.
It's probably harmless since each device would only use
a few bytes, and most devices don't need any I/O ports
at all.
Arnd
next prev parent reply other threads:[~2023-02-28 16:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 16:47 [PATCH 00/16] Qcom: Fix PCI I/O range defined in devicetree Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 01/16] arm64: dts: qcom: sdm845: Fix the PCI I/O port range Manivannan Sadhasivam
2023-02-28 16:55 ` Arnd Bergmann [this message]
2023-02-28 16:47 ` [PATCH 02/16] arm64: dts: qcom: msm8998: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 03/16] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 04/16] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 05/16] arm64: dts: qcom: ipq8074: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 06/16] arm64: dts: qcom: ipq6018: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 07/16] arm64: dts: qcom: msm8996: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 08/16] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 09/16] arm64: dts: qcom: qcs404: Use 0x prefix for the PCI I/O and MEM ranges Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 10/16] arm64: dts: qcom: sc8280xp: Fix the PCI I/O port range Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 11/16] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 12/16] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 13/16] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 14/16] ARM: dts: qcom: apq8064: Use 0x prefix for the PCI I/O and MEM ranges Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 15/16] ARM: dts: qcom: ipq4019: Fix the PCI I/O port range Manivannan Sadhasivam
2023-02-28 16:47 ` [PATCH 16/16] ARM: dts: qcom: ipq8064: " Manivannan Sadhasivam
2023-02-28 16:58 ` [PATCH 00/16] Qcom: Fix PCI I/O range defined in devicetree Arnd Bergmann
2023-03-01 11:29 ` Manivannan Sadhasivam
2023-03-01 11:57 ` Arnd Bergmann
2023-02-28 17:29 ` Andrew Halaney
2023-03-01 11:32 ` Manivannan Sadhasivam
2023-03-16 3:20 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e69e526-c270-49a0-bf00-8418d1aed121@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox