Re: [PATCH] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent

Andrew Halaney
2024-04-30T18:18:26Z

On Thu, Apr 25, 2024 at 04:07:10PM -0700, Sagar Cheluvegowda wrote:
> Ethernet devices are cache coherent, mark it as such in the dtsi.
>
> Change-Id: Id180fae617f2e348c0a80c6664b131cc57fcb4d6
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>

In addition to what others have said, I think you should include
fixes tags for this, so something like:

Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")

to indicate this isn't just an improvement, but a proper bug fix.

Thanks,
Andrew