From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288CB19CCED; Tue, 27 Aug 2024 09:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724751594; cv=none; b=b7/jLPcbR2WHexBrJIFM/YCD8UH0/xNlNUPNXR/YZYxt2sVf8RDcQFXNz60G5+XX0gqmocZS2hoEh5l6Ydh00Yx1/WeKwuvWzw/rX/KnaCQ/m8t1yh4KX6vAsctiZ3yRZI78J61PvPiT6WairrF8AlznpW4JDXn0jM3XX/AlW2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724751594; c=relaxed/simple; bh=tTOdIYGEpUYrs7p5lDLezY5WL2wSjJff06XLjNySGvo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rZ+X/YRlxskfIRxJoF/DnaiUXbz3RZThbxSR1tR9tW3FpsQEMvjX9vj+0AfUQJvviEcirgR+T1C2LDd/gBzzTuNkPjBMKMdeaNpqoBHCPlX2Le5qcbaSq+rG11fK4pE0NtIqiKkeNj9dLRqzVoRsWPO1ZigqIlXuwMRLN/TSZ1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JdQXMcf9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JdQXMcf9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38584C567ED; Tue, 27 Aug 2024 09:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724751593; bh=tTOdIYGEpUYrs7p5lDLezY5WL2wSjJff06XLjNySGvo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JdQXMcf9y+ZrimiTarq68UJig4tgGu8n6JaFX46gXQIF5W5t5Oy1Oe2VPjHl7h9h/ JDLr7WsHFWSurjIcf5XRGIcW/Tnn4zEV3YijsbjVSuSn2RSQMEo0OLjKsf7BCqan5A //YhAZd0HHeNUtNmfR33PuDttndBa8vmcyTpGdcYKFxiw8BymoZrVjuEdpYjybPNVR 01ufIm0CyAm6wA4tsWnUj7nTZQI1svsFDOKptC6m3qh7ZXxfTjlrC1ATLoVGNsqF5T DZMEn1K0GuwUw1eyaiGxwABan5lnvEy1lEyOdti8tKMXg1RcwuIbblIxYNqkt0aaSA zmmOyK4oeguYA== Message-ID: <1efd71c4-3bee-4c71-9e40-1284b9483824@kernel.org> Date: Tue, 27 Aug 2024 11:39:45 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] drm/msm/dpu: don't play tricks with debug macros To: Dmitry Baryshkov , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jeykumar Sankaran References: <20240802-dpu-fix-wb-v2-0-7eac9eb8e895@linaro.org> <20240802-dpu-fix-wb-v2-2-7eac9eb8e895@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240802-dpu-fix-wb-v2-2-7eac9eb8e895@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2.08.2024 9:47 PM, Dmitry Baryshkov wrote: > DPU debugging macros need to be converted to a proper drm_debug_* > macros, however this is a going an intrusive patch, not suitable for a > fix. Wire DPU_DEBUG and DPU_DEBUG_DRIVER to always use DRM_DEBUG_DRIVER > to make sure that DPU debugging messages always end up in the drm debug > messages and are controlled via the usual drm.debug mask. > > I don't think that it is a good idea for a generic DPU_DEBUG macro to be > tied to DRM_UT_KMS. It is used to report a debug message from driver, so by > default it should go to the DRM_UT_DRIVER channel. While refactoring > debug macros later on we might end up with particular messages going to > ATOMIC or KMS, but DRIVER should be the default. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > index e2adc937ea63..935ff6fd172c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > @@ -31,24 +31,14 @@ > * @fmt: Pointer to format string > */ > #define DPU_DEBUG(fmt, ...) \ > - do { \ > - if (drm_debug_enabled(DRM_UT_KMS)) \ > - DRM_DEBUG(fmt, ##__VA_ARGS__); \ > - else \ > - pr_debug(fmt, ##__VA_ARGS__); \ > - } while (0) > + DRM_DEBUG_DRIVER(fmt, ##__VA_ARGS__) Should we just get rid of these macros at this point and use DRM_DEBUG_DRIVER directly? Konrad