From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C93E225A3D for ; Fri, 24 Oct 2025 02:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761271823; cv=none; b=d6fEZBqjfr1CD8zhyqO0nrlX6kPf7zW6rdoGguB4OXfgy+nnkpFMRpH7zCZbmDoOB1Hux3n2XzRPlVEyPabtPmGUGpHsr8zsgAjb12fdQOjvEvs3wKuTfKXiHvRot6MnbicGVxb+YjNnvU55tSR40W1ekO1VMnEqOADlcISZg0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761271823; c=relaxed/simple; bh=bWhghqbkZF5R6OM/wCGrP0IOos+1Kse2GUZQVx+q0nY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PtOC0xa2qcEATpa+bzi8kHFMe6XM+qYZsJy4/d8dp1/TjIkbyIxfcP3UVIabXeHXACqklApSTvesP5vCZhcwxJkv4TdK9Cu5ZwFQDvRoAGaHgSvwX9SyTPuB0T/1PcRfRUjOQjp4JKOdRc3T2aGDyOaR6921ZlLbYpLOBrJaAdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C/z3P8Gh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C/z3P8Gh" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59NEtMcl022471 for ; Fri, 24 Oct 2025 02:10:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PGCvJi9rEoMOgH9ee/rqu2BrVYz/eqz38q5hdOmWyuU=; b=C/z3P8Gh3PHag14N Pjfp0iJb/cqnKyA1AVEapwbGM/cJfYmN8DWtrIyANYnt3O/SxvWyxKBG1CnVpm1i xiaeyezCZl0+/zDaqLQJW4YAlNRe+6c5OVsmgu0x4F3e5qisqxDc3QE6IOMrLk78 yRJNl7uTKrqzirSsLiMOHoOmSYRZR2iqZSGOIJ9KtiOEr+l50NMUCMDvdcpNM9P7 kU3Y+DvJCvmYm6EX1MQLOytQ4zfZxbBLfkzUlAHAFR0JS4fuw8sKl3P0f1hDtOI0 zSCAh6sfZRvOJ1ybyrqX6wbD8UlEX/BYbBw/X4eGrIqCZ7ABrICt+hCgRQPeFULs xfc3ZQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v1w8afqw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 24 Oct 2025 02:10:20 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-32ee62ed6beso2353098a91.2 for ; Thu, 23 Oct 2025 19:10:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761271815; x=1761876615; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PGCvJi9rEoMOgH9ee/rqu2BrVYz/eqz38q5hdOmWyuU=; b=pFdR4BoWL+bCbcNfegStgexdaGTzGzvmQmf8rwtWdDnxJJZKLAUO/Scx1PHprYXRBL yC/Uibr+6HHzU6+O4pwdSdj20BOtK7biifIG0nIdqWNekFYxJyqzenIsPjuLFHN2IYS/ WYrapjDpIBfGfeSwXXTcPFzXaYYXxdG5YFhAgMCB+2xFGllJCkNugDPJHM+EkRClkSG9 q69ow/JRwoCb5Hp+97AMHJPkMDFhzLVummKtnMsf+/sKRjHLp4nzEG7nN1OvkX5n+YOy 0QVsNcOp2GHbGaBpRFJu8/SDP430oBER2sd4HYvtWFRYKffDc8DrpXzevIshCyUhfxqJ ljTA== X-Forwarded-Encrypted: i=1; AJvYcCUvGsUuhZFQ0iUnhYZstv7OQcnEEk3WV719c+1CvQ6iMVV8FpiN754FVymBQARwLWQNy3peQmzCtT9tQlMR@vger.kernel.org X-Gm-Message-State: AOJu0Yy1owbAhPhSWQeSjzY35FlA0RJK0srxUQwjAqqH1FhpoeeK2aQM dJzu9kdv+uGHtCSHVvk/SSVkrUO+fihdjyPkwbPj0TQ/CBDYodJgGcJvft2wD7JDkwprx7vfa5c 1pAHD8XbMO1tM2xOvwG+QldYSvViRj6iaz06mt2d4oYHc505vNoygEvwsSj9udnj5tfA2 X-Gm-Gg: ASbGncvkj1kkoKFrSDVPebldqigAq7Rk1ecX9pwlx0eGrUt3gfhR9QsAy5wVUBstQ2+ JMLd6AFRE4MpSdVBf2qj/hE8RGbbZmwfNB2Es6qA8b0hiPuaYBhpS0puvQk2/BLOOBXi2HscoDc /fGUFdHXm9JZkqXUyfq7YU71XSwh9ef0Hc3z6rbSvql3R/ilfy8RT+/mFsNd6lzl88B4+JlAAi3 i13RAzKnU2hosyuAn4XvLCrWNYNCP0D5A6YSkiuQpOCiseK9eAhi/G931uy2YbUzXEWRXTsQNYk LfH+jsJXs5teJSNOykdUs5ByPc/wv7vMvf2J8W12g8xNiyPKSp8Mnh82zGX0UJA/jOLIGfb8e5E 3HReP8TKBrw0MIq0OA30us4ULtQMVbsJuuSpo3FddbFRTDlSvixH3XhCYIswJNGHqc+GaKg== X-Received: by 2002:a17:903:2444:b0:264:8a8d:92e8 with SMTP id d9443c01a7336-2948ba950b8mr7646565ad.59.1761271814901; Thu, 23 Oct 2025 19:10:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0Th1WmQpEggqKtoeq8EtSC4CLCeFVp3H06Pt4dnKJUtaqYK88vCk/JQeaiuW7BPm22gLpXg== X-Received: by 2002:a17:903:2444:b0:264:8a8d:92e8 with SMTP id d9443c01a7336-2948ba950b8mr7646255ad.59.1761271814441; Thu, 23 Oct 2025 19:10:14 -0700 (PDT) Received: from [10.133.33.160] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2946dfc274csm38536765ad.74.2025.10.23.19.10.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 19:10:13 -0700 (PDT) Message-ID: <1f98f83f-328f-47c8-84e7-2c77abb37a6a@oss.qualcomm.com> Date: Fri, 24 Oct 2025 10:10:05 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-remoteproc-v1-0-611bf7be8329@oss.qualcomm.com> <20250924-knp-remoteproc-v1-2-611bf7be8329@oss.qualcomm.com> <5820a9a9-4474-4c4d-905c-0efd9442e5e1@oss.qualcomm.com> <540b1de6-c959-4911-925f-8163f5fa5147@oss.qualcomm.com> <7952ed3d-f019-4593-af43-b2df7f738d04@oss.qualcomm.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAxNSBTYWx0ZWRfX1Q8vv3QcJaDB IgT8Tj2f57PSZYGp8t23A0a1RsIolhv4NU4+tHAJH35XKGiE/MBDW/8gedjq5ntkVCqIsSUqn8D ckDjF8hC+/256SwgTHmjH5UgDN+VfLsh8+uzIk3Y7K0ccl1s1gQof18IgrzAIQ/88kyzdvYyTOS jRPtfMzD/ET8pSefG+MbQ8YLPDBgriX3iBq9JAlL5tmRJ/nZQkUqUDrvQuCxqVWVVX9sEXWJXyM BMrqVYbm0N1D8y3cFtutj7GutnlrrAOeBrv4bWPULQctulqKv3gw08Mvb2BmouTH48CK/20WARS riJ4cYhy+KDw1cZs0o05iZ5SzocwFHufm10BBI6jqn0LhWurRB9JnQA8UbN1ex1gjrGoSRSTRfp g9LftwNmZG01D5FlsgoM6jcjGSg2YA== X-Authority-Analysis: v=2.4 cv=bNUb4f+Z c=1 sm=1 tr=0 ts=68fae00c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=UIbmj66A9DVWYICVwn8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: ZXipk55dIsHJ4Btp_kdPVOHpHkU3cxFe X-Proofpoint-ORIG-GUID: ZXipk55dIsHJ4Btp_kdPVOHpHkU3cxFe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-23_03,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 adultscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180015 On 10/23/2025 2:28 PM, Krzysztof Kozlowski wrote: > On 23/10/2025 06:07, Jingyi Wang wrote: >> >> >> On 10/9/2025 6:29 PM, Krzysztof Kozlowski wrote: >>> On 29/09/2025 19:03, Dmitry Baryshkov wrote: >>>> On Mon, Sep 29, 2025 at 05:41:10PM +0800, Jingyi Wang wrote: >>>>> >>>>> >>>>> On 9/29/2025 5:34 PM, Dmitry Baryshkov wrote: >>>>>> On Mon, Sep 29, 2025 at 02:20:54PM +0800, Jingyi Wang wrote: >>>>>>> >>>>>>> >>>>>>> On 9/25/2025 9:48 AM, Krzysztof Kozłowski wrote: >>>>>>>> On Thu, 25 Sept 2025 at 08:37, Jingyi Wang wrote: >>>>>>>>> >>>>>>>>> Add remote processor PAS loader for Kaanapali CDSP processor, compatible >>>>>>>>> with earlier SM8550 with minor difference: one more sixth "shutdown-ack" >>>>>>>>> interrupt. >>>>>>>>> >>>>>>>>> Signed-off-by: Jingyi Wang >>>>>>>>> --- >>>>>>>>> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 19 +++++++++++++++++++ >>>>>>>>> 1 file changed, 19 insertions(+) >>>>>>>>> >>>>>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>>> index be9e2a0bc060..031fdf36a66c 100644 >>>>>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >>>>>>>>> @@ -35,6 +35,9 @@ properties: >>>>>>>>> - items: >>>>>>>>> - const: qcom,sm8750-cdsp-pas >>>>>>>>> - const: qcom,sm8650-cdsp-pas >>>>>>>>> + - items: >>>>>>>>> + - const: qcom,kaanapali-cdsp-pas >>>>>>>>> + - const: qcom,sm8550-cdsp-pas >>>>>>>> >>>>>>>> >>>>>>>> This time maybe without HTML: >>>>>>>> >>>>>>>> This looks wrong. This is not compatible with SM8550. >>>>>>> >>>>>>> Could you point out what is the difference from your perspecetive? >>>>>>> it is the same as SM8550 except for there is one more interrupt, >>>>>>> which is also described in this patch. >>>>>> >>>>>> I'd second Krzysztof here. Your description points out that it is _not_ >>>>>> compatible to SM8550. >>>>>> >>>>> >>>>> Here is the binding for sm8750 cdsp. Fallback to sm8650 but describe the >>>>> difference in interrupt: >>>>> https://lore.kernel.org/all/20250221160036.159557-1-krzysztof.kozlowski@linaro.org/ >>>> >>>> Interesting. Let's wait for Krzysztof's response then. >>>> >>> >>> >>> Because it is evolution of sm8750, so it did not go back to old design. >>> from three generations ago. This is compatible with sm8750 or with sm8650. >>> >>> >>> Best regards, >>> Krzysztof >> >> Hi Krzysztof， >> >> I tested with falling back to sm8650 cdsp but it will fail with: >> [ 4.739615] qcom_q6v5_pas 26300000.remoteproc: unable to resolve shareable memory-region index 0 >> >> sm8550 and kaanapali define 2 memory regions: >> "memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>;" >> >> sm8650 and sm8750 define 3 memory regions: >> "memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>, <&global_sync_mem>;" >> with the driver: >> >> static const struct qcom_pas_data sm8650_cdsp_resource = { >> .crash_reason_smem = 601, >> .firmware_name = "cdsp.mdt", >> .dtb_firmware_name = "cdsp_dtb.mdt", >> <...> >> .region_assign_idx = 2, >> .region_assign_count = 1, >> .region_assign_shared = true, >> .region_assign_vmid = QCOM_SCM_VMID_CDSP, >> }; >> >> When kaanapali fallback to sm8650 it cannot parse this region_assign_idx. >> >> So shall we still fallback to sm8550 or define a new node "kaanapali_cdsp_resource" >> in the driver? > > And partially the point here is that you might need the third region, no? > Best regards, > Krzysztof On kaanapali, the global_sync_mem region is not managed by kernel, so it should be removed. Thanks, Jingyi