From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D85FCD4850 for ; Fri, 22 Sep 2023 19:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbjIVTBl (ORCPT ); Fri, 22 Sep 2023 15:01:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233543AbjIVTBk (ORCPT ); Fri, 22 Sep 2023 15:01:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEC48E8 for ; Fri, 22 Sep 2023 12:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695409253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=llC9/wUzzd4JVzDSD0PHMCO4lX+W74lZOeDntPKMIjc=; b=Cw0hPUDDvWtHCI49HtRKihJGXxrmxydM2vKrAPFbDHZlPeaeocyI+I8MtFuOmnk1Stlori RZgDektHuX5/x3S9S/AU+ra93dP9vP5+j6O4i4/hUmakNvpp655IY1JEMkmwSwCryXFEMA SRZrGEDpjrrc35jH0njVMH35KDZ8W7Q= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-LO9Uiw7mOIeZ4-Pd9vSKsg-1; Fri, 22 Sep 2023 15:00:51 -0400 X-MC-Unique: LO9Uiw7mOIeZ4-Pd9vSKsg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-65af09eaa88so3936126d6.0 for ; Fri, 22 Sep 2023 12:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695409250; x=1696014050; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=llC9/wUzzd4JVzDSD0PHMCO4lX+W74lZOeDntPKMIjc=; b=YGH7d/Cg30n7MxF9wxeAXSeRgI8hPTqu4vkPaCunWw4vyvhIGJmIxF+IT2XRBKV0H+ QllnNh8JEhGo3YUyCFtDBR/sQOlGo3sUXg9fhRvcKVq93dX3q0QXsSbO3XJwCnjCth6D K88scrtfVB/iRPSZhGnc1wU8i3EF8dYvEMYQTuyA9QbSzvOyjK+LQx8Y5zni0NBgEBry Dc0InMOoinAz5kxc6IMqGYPcat5Ay48DQ28hH5zFaFq+GbvSLxZaNnmYBZAXtLOsqXd1 eEflIRi0Xd8aDSo+jYeTbA94Q9bsoLYyXHZQHKej6H4N/PuUaphODgVdnEgzsGoxMzrB G9UA== X-Gm-Message-State: AOJu0YxwsDIgRyWFUugGnaXPVr10rjX/nYlJXpzypblHSVIxfnxERduu fiyL6c1MhbpVu0g6qY4SeL3KPZfXualxP4F30NFU2jGpku1S8BnvxgYZNN74Mv+SJ4nLChD3B8T OPAyvP6IKfXBZ8O075KwtJOq3DA== X-Received: by 2002:a05:6214:1845:b0:655:d2c7:a9d1 with SMTP id d5-20020a056214184500b00655d2c7a9d1mr187777qvy.14.1695409250681; Fri, 22 Sep 2023 12:00:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcAhYi3agHEIh1mExaRpOkIAUDfxEWkbuUfbk0Y5Ex6ReRQkYaRYp/G33/F11gHisOBD3h3Q== X-Received: by 2002:a05:6214:1845:b0:655:d2c7:a9d1 with SMTP id d5-20020a056214184500b00655d2c7a9d1mr187719qvy.14.1695409250417; Fri, 22 Sep 2023 12:00:50 -0700 (PDT) Received: from ?IPv6:2600:4040:5c6c:a300::feb? ([2600:4040:5c6c:a300::feb]) by smtp.gmail.com with ESMTPSA id w6-20020a0ce106000000b0064f50e2c551sm1671895qvk.1.2023.09.22.12.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 12:00:49 -0700 (PDT) Message-ID: <1fc22ed54041660dfff5b7f3cc69708fd4ac0472.camel@redhat.com> Subject: Re: [PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by From: Lyude Paul To: Kees Cook , David Airlie Cc: Ben Skeggs , Karol Herbst , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Emma Anholt , Evan Quan , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , Xiaojian Du , Huang Rui , Kevin Wang , Hawking Zhang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Chris Wilson , John Harrison , Andi Shyti , Matthew Brost , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , Bjorn Andersson , Maxime Ripard , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Zack Rusin , VMware Graphics Reviewers , Melissa Wen , Nathan Chancellor , Nick Desaulniers , Tom Rix , Le Ma , Lijo Lazar , Yifan Zhang , Prike Liang , Lang Yu , Tejas Upadhyay , Nirmoy Das , Andrzej Hajda , Neil Armstrong , Kuogee Hsieh , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, virtualization@lists.linux-foundation.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Date: Fri, 22 Sep 2023 15:00:47 -0400 In-Reply-To: <20230922173216.3823169-5-keescook@chromium.org> References: <20230922173110.work.084-kees@kernel.org> <20230922173216.3823169-5-keescook@chromium.org> Organization: Red Hat Inc. Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Reviewed-by: Lyude Paul Thanks! On Fri, 2023-09-22 at 10:32 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_b= y > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUND= S > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). >=20 > As found with Coccinelle[1], add __counted_by for struct nvkm_perfdom. >=20 > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/c= ounted_by.cocci >=20 > Cc: Ben Skeggs > Cc: Karol Herbst > Cc: Lyude Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Signed-off-by: Kees Cook > --- > drivers/gpu/drm/nouveau/nvkm/engine/pm/priv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/priv.h b/drivers/gpu/= drm/nouveau/nvkm/engine/pm/priv.h > index 6ae25d3e7f45..c011227f7052 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/priv.h > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/priv.h > @@ -82,7 +82,7 @@ struct nvkm_perfdom { > u8 mode; > u32 clk; > u16 signal_nr; > - struct nvkm_perfsig signal[]; > + struct nvkm_perfsig signal[] __counted_by(signal_nr); > }; > =20 > struct nvkm_funcdom { --=20 Cheers, Lyude Paul (she/her) Software Engineer at Red Hat