Re: [PATCH 3/7] arm: msm: smd: convert unsigned addr to unsigned long

[Pavel Machek <pavel@ucw.cz>]

On Fri 2010-03-26 16:55:21, Daniel Walker wrote:
> "unsigned" translates to "unsigned int", but this value holds an
> address. We always want to use unsigned long for addresses since
> it will change size to fit the machine.
> 
> This just convert the one address holder to unsigned long.
> 
> Signed-off-by: Daniel Walker <dwalker@codeaurora.org>

ACK.

> ---
>  arch/arm/mach-msm/smd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
> index 130b7a7..2e32d9a 100644
> --- a/arch/arm/mach-msm/smd.c
> +++ b/arch/arm/mach-msm/smd.c
> @@ -872,9 +872,9 @@ static irqreturn_t smsm_irq_handler(int irq, void *data)
>  int smsm_change_state(enum smsm_state_item item,
>  		      uint32_t clear_mask, uint32_t set_mask)
>  {
> +	unsigned long addr = smd_info.state + item * 4;
>  	unsigned long flags;
>  	unsigned state;
> -	unsigned addr = smd_info.state + item * 4;
>  
>  	if (!smd_info.ready)
>  		return -EIO;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html