* [PATCH 3/7] arm: msm: smd: convert unsigned addr to unsigned long
@ 2010-03-26 23:55 Daniel Walker
2010-03-27 6:17 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Walker @ 2010-03-26 23:55 UTC (permalink / raw)
To: linux-arm-msm
"unsigned" translates to "unsigned int", but this value holds an
address. We always want to use unsigned long for addresses since
it will change size to fit the machine.
This just convert the one address holder to unsigned long.
Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
---
arch/arm/mach-msm/smd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
index 130b7a7..2e32d9a 100644
--- a/arch/arm/mach-msm/smd.c
+++ b/arch/arm/mach-msm/smd.c
@@ -872,9 +872,9 @@ static irqreturn_t smsm_irq_handler(int irq, void *data)
int smsm_change_state(enum smsm_state_item item,
uint32_t clear_mask, uint32_t set_mask)
{
+ unsigned long addr = smd_info.state + item * 4;
unsigned long flags;
unsigned state;
- unsigned addr = smd_info.state + item * 4;
if (!smd_info.ready)
return -EIO;
--
1.6.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 3/7] arm: msm: smd: convert unsigned addr to unsigned long
2010-03-26 23:55 [PATCH 3/7] arm: msm: smd: convert unsigned addr to unsigned long Daniel Walker
@ 2010-03-27 6:17 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2010-03-27 6:17 UTC (permalink / raw)
To: Daniel Walker; +Cc: linux-arm-msm
On Fri 2010-03-26 16:55:21, Daniel Walker wrote:
> "unsigned" translates to "unsigned int", but this value holds an
> address. We always want to use unsigned long for addresses since
> it will change size to fit the machine.
>
> This just convert the one address holder to unsigned long.
>
> Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
ACK.
> ---
> arch/arm/mach-msm/smd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
> index 130b7a7..2e32d9a 100644
> --- a/arch/arm/mach-msm/smd.c
> +++ b/arch/arm/mach-msm/smd.c
> @@ -872,9 +872,9 @@ static irqreturn_t smsm_irq_handler(int irq, void *data)
> int smsm_change_state(enum smsm_state_item item,
> uint32_t clear_mask, uint32_t set_mask)
> {
> + unsigned long addr = smd_info.state + item * 4;
> unsigned long flags;
> unsigned state;
> - unsigned addr = smd_info.state + item * 4;
>
> if (!smd_info.ready)
> return -EIO;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-27 6:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-26 23:55 [PATCH 3/7] arm: msm: smd: convert unsigned addr to unsigned long Daniel Walker
2010-03-27 6:17 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).