From: Arjan van de Ven <arjan@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Saravana Kannan <skannan@codeaurora.org>,
cpufreq <cpufreq@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Dave Jones <davej@redhat.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Thomas Renninger <trenn@suse.de>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: CPUfreq - udelay() interaction issues
Date: Fri, 23 Apr 2010 12:22:59 -0700 [thread overview]
Message-ID: <20100423122259.49e0416a@infradead.org> (raw)
In-Reply-To: <20100423184042.GA16190@Krystal>
On Fri, 23 Apr 2010 14:40:42 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> [CCing Arjan, who seems to have played a lot with ondemand lately]
>
> * Saravana Kannan (skannan@codeaurora.org) wrote:
> > Resending email to "cc" the maintainers.
> >
> > Maintainers,
> >
> > Any comments?
> >
> > -Saravana
> >
> > Saravana Kannan wrote:
> >> Hi,
> >>
> >> I think there are a couple of issues with cpufreq and udelay
> >> interaction. But that's based on my understanding of cpufreq. I
> >> have worked with it for sometime now, so hopefully I not
> >> completely wrong. So, I will list my assumptions and what I think
> >> is/are the issue(s) and their solutions.
> >>
> >> Please correct me if I'm wrong and let me know what you think.
> >>
> >> Assumptions:
> >> ============
> >> * Let's assume ondemand governor is being used.
> >> * Ondemand uses one timer per core and they have CPU affinity set.
> >> * For SMP, CPUfreq core expects the CPUfreq driver to adjust the
> >> per-CPU jiffies.
> >> * P1 indicates for lower CPU perfomance levels and P2 indicates a
> >> much higher CPU pref level (say 10 times faster).
> >>
so in reality, all hardware that does coordination between cores/etc
like this also has a tsc that is invariant of the actual P state.
If there are exceptions, those have a problem, but I can't think of any
right now.
Once the TSC is invariant of P state, udelay() is fine, since that goes
of the tsc, not of some delay loop kind of thing....
next prev parent reply other threads:[~2010-04-23 19:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 3:34 CPUfreq - udelay() interaction issues Saravana Kannan
2010-04-22 21:22 ` Saravana Kannan
2010-04-22 23:18 ` Thomas Renninger
2010-04-22 23:37 ` Saravana Kannan
2010-04-22 23:21 ` Saravana Kannan
2010-04-23 18:40 ` Mathieu Desnoyers
2010-04-23 19:22 ` Arjan van de Ven [this message]
2010-04-23 19:55 ` Mathieu Desnoyers
2010-04-24 18:56 ` Arjan van de Ven
2010-04-24 21:00 ` Mathieu Desnoyers
2010-04-24 23:20 ` Arjan van de Ven
2010-04-24 2:57 ` Saravana Kannan
2010-04-24 2:49 ` Saravana Kannan
2010-04-24 5:56 ` Pavel Machek
2010-04-24 13:58 ` Mathieu Desnoyers
2010-04-27 23:41 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423122259.49e0416a@infradead.org \
--to=arjan@infradead.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=skannan@codeaurora.org \
--cc=trenn@suse.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).