From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ksp.mff.cuni.cz ([195.113.26.206]:58482 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751048Ab0DXFBn (ORCPT ); Sat, 24 Apr 2010 01:01:43 -0400 Date: Sat, 24 Apr 2010 07:01:40 +0200 From: Pavel Machek Subject: Re: [PATCH 2/2] arm: msm: smd: fix initcall prototype compiler warning Message-ID: <20100424050140.GC7561@elf.ucw.cz> References: <> <1272046286-9429-1-git-send-email-dwalker@codeaurora.org> <1272046286-9429-2-git-send-email-dwalker@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1272046286-9429-2-git-send-email-dwalker@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Daniel Walker Cc: linux-arm-msm@vger.kernel.org On Fri 2010-04-23 11:11:26, Daniel Walker wrote: > This fixes the following warning, > > arch/arm/mach-msm/smd_debug.c:240: warning: initialization from incompatible pointer type > > Signed-off-by: Daniel Walker ACK. > --- > arch/arm/mach-msm/smd_debug.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-msm/smd_debug.c b/arch/arm/mach-msm/smd_debug.c > index 0cc3ef8..3b2dd71 100644 > --- a/arch/arm/mach-msm/smd_debug.c > +++ b/arch/arm/mach-msm/smd_debug.c > @@ -221,13 +221,13 @@ static void debug_create(const char *name, mode_t mode, > debugfs_create_file(name, mode, dent, fill, &debug_ops); > } > > -static void smd_debugfs_init(void) > +static int smd_debugfs_init(void) > { > struct dentry *dent; > > dent = debugfs_create_dir("smd", 0); > if (IS_ERR(dent)) > - return; > + return 1; > > debug_create("ch", 0444, dent, debug_read_ch); > debug_create("stat", 0444, dent, debug_read_stat); > @@ -235,6 +235,8 @@ static void smd_debugfs_init(void) > debug_create("version", 0444, dent, debug_read_version); > debug_create("tbl", 0444, dent, debug_read_alloc_tbl); > debug_create("build", 0444, dent, debug_read_build_id); > + > + return 0; > } > > late_initcall(smd_debugfs_init); -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html