From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:40245 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755959Ab0GLXqO (ORCPT ); Mon, 12 Jul 2010 19:46:14 -0400 Date: Mon, 12 Jul 2010 16:46:04 -0700 From: Andrew Morton Subject: Re: [PATCH v2] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver. Message-Id: <20100712164604.bfd5c142.akpm@linux-foundation.org> In-Reply-To: <4C3AD87C.1010407@codeaurora.org> References: <1278617834-14970-1-git-send-email-gbean@codeaurora.org> <4C370EB4.4040906@codeaurora.org> <4C3AD87C.1010407@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Trilok Soni Cc: Gregory Bean , khali@linux-fr.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org On Mon, 12 Jul 2010 14:25:24 +0530 Trilok Soni wrote: > Hi Jean, Andrew, > > On 7/9/2010 5:27 PM, Trilok Soni wrote: > > On 7/9/2010 1:07 AM, Gregory Bean wrote: > >> Add support for Semtech SX150-series I2C GPIO expanders. > >> Compatible models include: > >> > >> 8 bits: sx1508q > >> 16 bits: sx1509q > >> > >> Signed-off-by: Gregory Bean > >> --- > >> drivers/gpio/Kconfig | 11 + > >> drivers/gpio/Makefile | 1 + > >> drivers/gpio/sx150x.c | 646 ++++++++++++++++++++++++++++++++++++++++++++ > >> include/linux/i2c/sx150x.h | 78 ++++++ > >> 4 files changed, 736 insertions(+), 0 deletions(-) > >> create mode 100644 drivers/gpio/sx150x.c > >> create mode 100644 include/linux/i2c/sx150x.h > >> > > > > Looks good to me. > > > > Reviewed-by: Trilok Soni > > > > Any review comments on this new version of the driver? It looked OK to me. You should have received an email when I merged it into my tree?