[PATCH] introducing internal_phy_reset()

[PATCH] introducing internal_phy_reset()

[David Lanzendörfer]

Hi, the following function should work for hsusb.
I only need to know now, where it should be added to platform data exactly.
Best regards
	leviathan
---
 arch/arm/mach-msm/board-trout.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-msm/board-trout.c b/arch/arm/mach-msm/board-trout.c
index bc0afa4..59d7640 100644
--- a/arch/arm/mach-msm/board-trout.c
+++ b/arch/arm/mach-msm/board-trout.c
@@ -29,6 +29,7 @@
 
 #include "devices.h"
 #include "board-trout.h"
+#include "proc_comm.h"
 
 extern int trout_init_mmc(unsigned int);
 
@@ -63,6 +64,11 @@ static void __init trout_init_irq(void)
 	msm_init_irq();
 }
 
+static void internal_phy_reset(void)
+{
+	msm_proc_comm(PCOM_MSM_HSUSB_PHY_RESET,NULL,NULL);
+}
+
 static void __init trout_fixup(struct machine_desc *desc, struct tag *tags,
 				char **cmdline, struct meminfo *mi)
 {
-- 
1.6.4.4

Re: [PATCH] introducing internal_phy_reset()

[Daniel Walker]

On Fri, 2010-07-16 at 12:30 +0200, David Lanzendörfer wrote:
> Hi, the following function should work for hsusb.
> I only need to know now, where it should be added to platform data exactly.
> Best regards
> 	leviathan
> ---
>  arch/arm/mach-msm/board-trout.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-msm/board-trout.c b/arch/arm/mach-msm/board-trout.c
> index bc0afa4..59d7640 100644
> --- a/arch/arm/mach-msm/board-trout.c
> +++ b/arch/arm/mach-msm/board-trout.c
> @@ -29,6 +29,7 @@
>  
>  #include "devices.h"
>  #include "board-trout.h"
> +#include "proc_comm.h"
>  
>  extern int trout_init_mmc(unsigned int);
>  
> @@ -63,6 +64,11 @@ static void __init trout_init_irq(void)
>  	msm_init_irq();
>  }
>  
> +static void internal_phy_reset(void)
> +{
> +	msm_proc_comm(PCOM_MSM_HSUSB_PHY_RESET,NULL,NULL);
> +}

I think it's a good topic to discuss .. We could put the proc_comm
function into a header under mach-msm/include/mach/ then you can
includes that header into a driver like this,

#include <mach/mmc.h>

please be sure to look at how other drivers are doing this for hints on
how to move forward.

Daniel

-- 
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH] introducing internal_phy_reset()

[Timothy Meade]

On Thu, Jul 22, 2010 at 4:28 PM, Daniel Walker <dwalker@codeaurora.org> wrote:
> On Fri, 2010-07-16 at 12:30 +0200, David Lanzendörfer wrote:
>> Hi, the following function should work for hsusb.
>> I only need to know now, where it should be added to platform data exactly.
>> Best regards
>>       leviathan
>> ---
>>  arch/arm/mach-msm/board-trout.c |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-msm/board-trout.c b/arch/arm/mach-msm/board-trout.c
>> index bc0afa4..59d7640 100644
>> --- a/arch/arm/mach-msm/board-trout.c
>> +++ b/arch/arm/mach-msm/board-trout.c
>> @@ -29,6 +29,7 @@
>>
>>  #include "devices.h"
>>  #include "board-trout.h"
>> +#include "proc_comm.h"
>>
>>  extern int trout_init_mmc(unsigned int);
>>
>> @@ -63,6 +64,11 @@ static void __init trout_init_irq(void)
>>       msm_init_irq();
>>  }
>>
>> +static void internal_phy_reset(void)
>> +{
>> +     msm_proc_comm(PCOM_MSM_HSUSB_PHY_RESET,NULL,NULL);
>> +}
>
> I think it's a good topic to discuss .. We could put the proc_comm
> function into a header under mach-msm/include/mach/ then you can
> includes that header into a driver like this,
>
> #include <mach/mmc.h>
>
> please be sure to look at how other drivers are doing this for hints on
> how to move forward.
>
> Daniel
>

Is there some reason not to use a full transceiver PHY driver like PXA
does? The proc_comm calls are board/amss specific, assuming you are
exporting a function from the board you break multidevice kernels.

include/linux/usb/otg.h:extern struct otg_transceiver
*otg_get_transceiver(void);

Also, there is some hacked up code floating around to enable switch
the usb device from client to host? Is there a better and more sane
way to do this that fits in better with upstream?

Thanks,
Timothy Meade
tmzt #htc-linux (facebook.com/HTCLinux)