From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:55011 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759242Ab0JHUc2 (ORCPT ); Fri, 8 Oct 2010 16:32:28 -0400 Date: Fri, 8 Oct 2010 13:32:22 -0700 From: Tony Lindgren Subject: Re: [PATCH] serial: DCC(JTAG) serial and console emulation support Message-ID: <20101008203221.GM7558@atomide.com> References: <1286305668-19987-1-git-send-email-dwalker@codeaurora.org> <20101007212707.GI7558@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Nicolas Pitre Cc: Daniel Walker , linux-arm-msm@vger.kernel.org, "Hyok S. Choi" , linux-arm-kernel@lists.infradead.org, Jeff Ohlstein * Nicolas Pitre [101007 18:16]: > On Thu, 7 Oct 2010, Tony Lindgren wrote: > > > > Can you please pass the read and write functions to the driver > > in platform_data? We are already booting kernels with both > > ARMv6 and 7 compiled in. > > No. This has nothing to do with platform as this can be determined > within the driver itself. Would be much better to simply determine > which flavor to use at driver init time and assign two function pointers. In the long run some platform init code is needed for powering up the JTAG interface and take care of pin multiplexing etc. Also, isn't DCC (Debug Communications Channel) a JTAG standard? At least the following does not say anything about DCC being ARM specific: http://en.wikipedia.org/wiki/Joint_Test_Action_Group BTW, we already have ETM (Embedded Trace Module) in arch/arm/kernel/etm.c. That is set up as amba driver. Regards, Tony